openshift / origin

Conformance test suite for OpenShift
http://www.openshift.org
Apache License 2.0
8.49k stars 4.7k forks source link

NO-ISSUE: skip boot image tests on single node tests #29262

Closed djoshy closed 2 weeks ago

djoshy commented 2 weeks ago

The last set of timeout failures are isolated to SNO, I suspect this is because the controller waits for "one" control plane node to be up-to date. This can take an unpredicatable amount of time, depending on other cluster variables. Increasing the timeout helped a bit, but whenever SNO goes through a "slow" patch, these failures will creep up again. Further, boot images updates are not applicable for SNO, as they are never scaled up after installation - so updating the machineset in such a case is moot. Let's skip these tests for the SNO cases.

openshift-ci-robot commented 2 weeks ago

@djoshy: This pull request explicitly references no jira issue.

In response to [this](https://github.com/openshift/origin/pull/29262): >The [last set of timeout failures are isolated to SNO](https://sippy.dptools.openshift.org/sippy-ng/tests/4.18/analysis?test=%5Bsig-mco%5D%5BOCPFeatureGate%3AManagedBootImagesAWS%5D%5BSerial%5D%20Should%20update%20boot%20images%20on%20all%20MachineSets%20when%20configured%20%5Bapigroup%3Amachineconfiguration.openshift.io%5D%20%5BSuite%3Aopenshift%2Fconformance%2Fserial%5D&filters=%7B%22items%22%3A%5B%7B%22columnField%22%3A%22name%22%2C%22operatorValue%22%3A%22equals%22%2C%22value%22%3A%22%5Bsig-mco%5D%5BOCPFeatureGate%3AManagedBootImagesAWS%5D%5BSerial%5D%20Should%20update%20boot%20images%20on%20all%20MachineSets%20when%20configured%20%5Bapigroup%3Amachineconfiguration.openshift.io%5D%20%5BSuite%3Aopenshift%2Fconformance%2Fserial%5D%22%7D%2C%7B%22columnField%22%3A%22variants%22%2C%22not%22%3Atrue%2C%22operatorValue%22%3A%22contains%22%2C%22value%22%3A%22never-stable%22%7D%2C%7B%22columnField%22%3A%22variants%22%2C%22not%22%3Atrue%2C%22operatorValue%22%3A%22contains%22%2C%22value%22%3A%22aggregated%22%7D%5D%2C%22linkOperator%22%3A%22and%22%7D), I suspect this is because the controller waits for "one" control plane node to be up-to date. This can take an unpredicatable amount of time, depending on other cluster variables. Increasing [the timeout helped a bit](https://github.com/openshift/origin/pull/29210), but whenever SNO goes through a "slow" patch, these failures will creep up again. Further, boot images updates are not applicable for SNO, as they are never scaled up after installation - so updating the machineset in such a case is moot. Let's skip these tests for the SNO cases. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Forigin). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
djoshy commented 2 weeks ago

/test e2e-aws-ovn-single-node-techpreview-serial

djoshy commented 2 weeks ago

/retest-required

yuqi-zhang commented 2 weeks ago

/lgtm

openshift-ci[bot] commented 2 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: djoshy, yuqi-zhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[test/extended/machine_config/OWNERS](https://github.com/openshift/origin/blob/master/test/extended/machine_config/OWNERS)~~ [djoshy,yuqi-zhang] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 2 weeks ago

@djoshy: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-agnostic-ovn-cmd f12f3681157752fa948c634af99aae118167ec09 link false /test e2e-agnostic-ovn-cmd
ci/prow/e2e-metal-ipi-ovn-kube-apiserver-rollout f12f3681157752fa948c634af99aae118167ec09 link false /test e2e-metal-ipi-ovn-kube-apiserver-rollout
ci/prow/e2e-metal-ipi-ovn f12f3681157752fa948c634af99aae118167ec09 link false /test e2e-metal-ipi-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-bot commented 2 weeks ago

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-tests This PR has been included in build openshift-enterprise-tests-container-v4.18.0-202411051207.p0.ge6b7790.assembly.stream.el9. All builds following this will include this PR.