openshift / origin

Conformance test suite for OpenShift
http://www.openshift.org
Apache License 2.0
8.49k stars 4.7k forks source link

TRT-1871: Revert #29266 "NO-JIRA: Additional ROSA exceptions" #29271

Closed dgoodwin closed 2 weeks ago

dgoodwin commented 2 weeks ago

Reverts #29266 ; tracked by https://issues.redhat.com/browse/TRT-1871

Per OpenShift policy, we are reverting this breaking change to get CI and/or nightly payloads flowing again.

While we suspect the test is now finding a legit issue, payloads have blocked. We're going to revert and test a fix with an exception and a jira to address adding the pod requests for the network team.

To unrevert this, revert this PR, and layer an additional separate commit on top that addresses the problem. Before merging the unrevert, please run these jobs on the PR and check the result of these jobs to confirm the fix has corrected the problem:

/payload-aggregate periodic-ci-openshift-release-master-ci-4.18-upgrade-from-stable-4.17-e2e-aws-ovn-upgrade

CC: @stbenjam

PR created by Revertomatic:tm:
openshift-ci-robot commented 2 weeks ago

@dgoodwin: This pull request references TRT-1871 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to [this](https://github.com/openshift/origin/pull/29271): > >Reverts #29266 ; tracked by https://issues.redhat.com/browse/TRT-1871 > >Per [OpenShift policy](https://github.com/openshift/enhancements/blob/master/enhancements/release/improving-ci-signal.md#quick-revert), we are reverting this breaking change to get CI and/or nightly payloads flowing again. > >While we suspect the test is now finding a legit issue, payloads have blocked. We're going to revert and test a fix with an exception and a jira to address adding the pod requests for the network team. > >To unrevert this, revert this PR, and layer an additional separate commit on top that addresses the problem. Before merging the unrevert, please run these jobs on the PR and check the result of these jobs to confirm the fix has corrected the problem: > >``` >/payload-aggregate periodic-ci-openshift-release-master-ci-4.18-upgrade-from-stable-4.17-e2e-aws-ovn-upgrade >``` > >CC: @stbenjam > >
>PR created by Revertomatic:tm: >
> Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Forigin). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
dgoodwin commented 2 weeks ago

/override ci/prow/e2e-aws-ovn-kube-apiserver-rollout /override ci/prow/e2e-aws-ovn-fips /override ci/prow/e2e-aws-ovn-edge-zones /override ci/prow/e2e-aws-ovn-serial /override ci/prow/e2e-gcp-ovn /override ci/prow/e2e-aws-ovn-upgrade /override ci/prow/e2e-aws-ovn-single-node-upgrade /override ci/prow/e2e-gcp-ovn-upgrade /override ci/prow/e2e-gcp-ovn-rt-upgrade /override ci/prow/e2e-openstack-ovn /override ci/prow/e2e-metal-ipi-ovn-ipv6 /override ci/prow/e2e-aws-ovn-single-node-serial /override ci/prow/e2e-aws-ovn-single-node /override ci/prow/e2e-aws-ovn-microshift-serial /override ci/prow/e2e-aws-ovn-microshift /override ci/prow/e2e-metal-ipi-ovn /override ci/prow/e2e-gcp-csi /override ci/prow/e2e-metal-ipi-ovn-kube-apiserver-rollout

openshift-ci[bot] commented 2 weeks ago

@dgoodwin: Overrode contexts on behalf of dgoodwin: ci/prow/e2e-aws-ovn-edge-zones, ci/prow/e2e-aws-ovn-fips, ci/prow/e2e-aws-ovn-kube-apiserver-rollout, ci/prow/e2e-aws-ovn-microshift, ci/prow/e2e-aws-ovn-microshift-serial, ci/prow/e2e-aws-ovn-serial, ci/prow/e2e-aws-ovn-single-node, ci/prow/e2e-aws-ovn-single-node-serial, ci/prow/e2e-aws-ovn-single-node-upgrade, ci/prow/e2e-aws-ovn-upgrade, ci/prow/e2e-gcp-csi, ci/prow/e2e-gcp-ovn, ci/prow/e2e-gcp-ovn-rt-upgrade, ci/prow/e2e-gcp-ovn-upgrade, ci/prow/e2e-metal-ipi-ovn, ci/prow/e2e-metal-ipi-ovn-ipv6, ci/prow/e2e-metal-ipi-ovn-kube-apiserver-rollout, ci/prow/e2e-openstack-ovn

In response to [this](https://github.com/openshift/origin/pull/29271#issuecomment-2462512497): >/override ci/prow/e2e-aws-ovn-kube-apiserver-rollout >/override ci/prow/e2e-aws-ovn-fips >/override ci/prow/e2e-aws-ovn-edge-zones >/override ci/prow/e2e-aws-ovn-serial >/override ci/prow/e2e-gcp-ovn >/override ci/prow/e2e-aws-ovn-upgrade >/override ci/prow/e2e-aws-ovn-single-node-upgrade >/override ci/prow/e2e-gcp-ovn-upgrade >/override ci/prow/e2e-gcp-ovn-rt-upgrade >/override ci/prow/e2e-openstack-ovn >/override ci/prow/e2e-metal-ipi-ovn-ipv6 >/override ci/prow/e2e-aws-ovn-single-node-serial >/override ci/prow/e2e-aws-ovn-single-node >/override ci/prow/e2e-aws-ovn-microshift-serial >/override ci/prow/e2e-aws-ovn-microshift >/override ci/prow/e2e-metal-ipi-ovn >/override ci/prow/e2e-gcp-csi >/override ci/prow/e2e-metal-ipi-ovn-kube-apiserver-rollout > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
neisw commented 2 weeks ago

/lgtm

openshift-ci[bot] commented 2 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dgoodwin, neisw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[test/extended/operators/OWNERS](https://github.com/openshift/origin/blob/master/test/extended/operators/OWNERS)~~ [dgoodwin,neisw] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
neisw commented 2 weeks ago

/hold

neisw commented 2 weeks ago

/hold cancel

stbenjam commented 2 weeks ago

/skip

openshift-bot commented 2 weeks ago

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-tests This PR has been included in build openshift-enterprise-tests-container-v4.18.0-202411071810.p0.g3ac967d.assembly.stream.el9. All builds following this will include this PR.