search

openshift / origin

Conformance test suite for OpenShift
http://www.openshift.org
Apache License 2.0
8.49k stars 4.7k forks source link

SDN-5473: OVN-K: Port e2e tests for CUDN functionality, connectivity and isolation #29274

Open ormergi opened 2 weeks ago

ormergi commented 2 weeks ago

This PR adds e2e tests for OVN-Kuberentes CluserUserDefinedNetwork CRD, introduced by https://github.com/ovn-kubernetes/ovn-kubernetes/pull/4612.

Note to reviewer:

openshift-ci[bot] commented 2 weeks ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

openshift-ci-robot commented 2 weeks ago

@ormergi: This pull request references SDN-5473 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to [this](https://github.com/openshift/origin/pull/29274): >This PR adds e2e tests for OVN-Kuberentes CluserUserDefinedNetwork CRD, introduced by https://github.com/ovn-kubernetes/ovn-kubernetes/pull/4612. > >Note to reviewer: >- Tests has been added as is from U/S repo, no logical changes has been done. >- This PR depends on having the CRD deployed by CNO https://github.com/openshift/cluster-network-operator/pull/2558 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Forigin). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
ormergi commented 1 week ago

/test ?

openshift-ci[bot] commented 1 week ago

@ormergi: The following commands are available to trigger required jobs:

The following commands are available to trigger optional jobs:

Use /test all to run the following jobs that were automatically triggered:

In response to [this](https://github.com/openshift/origin/pull/29274#issuecomment-2470071215): >/test ? > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
ormergi commented 1 week ago

/test e2e-gcp-ovn-techpreview

openshift-ci-robot commented 1 week ago

@ormergi: This pull request references SDN-5473 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to [this](https://github.com/openshift/origin/pull/29274): >This PR adds e2e tests for OVN-Kuberentes CluserUserDefinedNetwork CRD, introduced by https://github.com/ovn-kubernetes/ovn-kubernetes/pull/4612. > >Note to reviewer: >- Tests has been added as is from U/S repo, no logical changes has been done. >- ~~This PR depends on having the CRD deployed by CNO https://github.com/openshift/cluster-network-operator/pull/2558~~ Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Forigin). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
ormergi commented 1 week ago

/test e2e-gcp-ovn-techpreview

jluhrsen commented 1 week ago

your tests are not registered with the label [Suite:openshift/conformance/parallel] and that's what we are running in that job with openshift-tests run openshift/conformance/parallel. You can get that fixed by running make update you can check locally with this command:

before make update

❯ ./openshift-tests run openshift/conformance/parallel --dry-run | rg 'should create NAD according to spec in each target namespace and report active namespaces'
I1114 14:15:55.181022 1641198 factory.go:193] Registered Plugin "containerd"
INFO[0000] Decoding provider                             clusterState="<nil>" discover=true dryRun=true func=DecodeProvider providerType=

after make update

❯ ./openshift-tests run openshift/conformance/parallel --dry-run | rg 'should create NAD according to spec in each target namespace and report active namespaces'
I1114 14:18:09.348749 1642240 factory.go:193] Registered Plugin "containerd"
INFO[0000] Decoding provider                             clusterState="<nil>" discover=true dryRun=true func=DecodeProvider providerType=
"[sig-network][OCPFeatureGate:NetworkSegmentation][Feature:UserDefinedPrimaryNetworks] when using openshift ovn-kubernetes ClusterUserDefinedNetwork CRD Controller should create NAD according to spec in each target namespace and report active namespaces [Suite:openshift/conformance/parallel]"
ormergi commented 1 week ago

@jluhrsen thank you!

openshift-ci[bot] commented 1 week ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ormergi Once this PR has been reviewed and has the lgtm label, please assign neisw for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openshift/origin/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
ormergi commented 1 week ago

/test e2e-gcp-ovn-techpreview

openshift-ci-robot commented 4 days ago

@ormergi: This pull request references SDN-5473 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to [this](https://github.com/openshift/origin/pull/29274): >This PR adds e2e tests for OVN-Kuberentes CluserUserDefinedNetwork CRD, introduced by https://github.com/ovn-kubernetes/ovn-kubernetes/pull/4612. > >Note to reviewer: >- Tests has been added as is from U/S repo, no logical changes has been done. >- Due to some flakes on OCP CI this PR also includes bits from https://github.com/ovn-kubernetes/ovn-kubernetes/pull/4842 >- ~~This PR depends on having the CRD deployed by CNO https://github.com/openshift/cluster-network-operator/pull/2558~~ Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Forigin). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
ormergi commented 4 days ago

/test e2e-gcp-ovn-techpreview

ormergi commented 4 days ago

/test e2e-gcp-ovn-techpreview

ormergi commented 2 days ago

/test e2e-gcp-ovn-techpreview

ormergi commented 1 day ago

/test e2e-gcp-ovn-techpreview

ormergi commented 1 day ago

/test e2e-gcp-ovn-techpreview

openshift-ci[bot] commented 1 day ago

@ormergi: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci-robot commented 17 hours ago

@ormergi: This pull request references SDN-5473 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to [this](https://github.com/openshift/origin/pull/29274): >This PR adds e2e tests for OVN-Kuberentes CluserUserDefinedNetwork CRD, introduced by https://github.com/ovn-kubernetes/ovn-kubernetes/pull/4612. > >Note to reviewer: >- Tests has been added as is from U/S repo, no logical changes has been done. >- Due to flakes on CI the following changes has been done: > - Cherry pick https://github.com/ovn-kubernetes/ovn-kubernetes/pull/4842, including: > - Add missing wait for CUDN status to populate. > - Since tests runs in parallel on TP lane, wait for CUDN objects to be gone when deleted. > - Prevent flakes when CUDN realted tests run in parallel by using random metadata.name for network related objects such as NAD, UDN and CUDN. > - In tests that create namespaces and pods, set the pods with PSA that meet the cluster. >- ~~This PR depends on having the CRD deployed by CNO https://github.com/openshift/cluster-network-operator/pull/2558~~ Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Forigin). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
ormergi commented 17 hours ago

/test e2e-gcp-ovn-techpreview

openshift-ci[bot] commented 17 hours ago

@ormergi: No presubmit jobs available for openshift/origin@master

In response to [this](https://github.com/openshift/origin/pull/29274#issuecomment-2491625190): >/test e2e-gcp-ovn-techpreview Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.