openshift / origin

Conformance test suite for OpenShift
http://www.openshift.org
Apache License 2.0
8.49k stars 4.7k forks source link

OCPBUGS-42532: Revert loosened policy test #29289

Closed ardaguclu closed 6 days ago

ardaguclu commented 1 week ago

Since https://github.com/openshift/openshift-apiserver/pull/458 has merged, we can revert https://github.com/openshift/origin/pull/29141

openshift-ci-robot commented 1 week ago

@ardaguclu: This pull request references Jira Issue OCPBUGS-42532, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/origin/pull/29289): >Since https://github.com/openshift/openshift-apiserver/pull/458 has merged, we can revert https://github.com/openshift/origin/pull/29141 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Forigin). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
ardaguclu commented 1 week ago

/cc @atiratree

ardaguclu commented 1 week ago

/jira refresh

openshift-ci-robot commented 1 week ago

@ardaguclu: This pull request references Jira Issue OCPBUGS-42532, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.18.0) matches configured target version for branch (4.18.0) * bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @zhouying7780

In response to [this](https://github.com/openshift/origin/pull/29289#issuecomment-2474276021): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Forigin). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
ardaguclu commented 1 week ago

/cc @stbenjam as the approver of the previous PR

atiratree commented 1 week ago

/lgtm @ardaguclu btw, it is better to use git revert for posterity

ardaguclu commented 1 week ago

/lgtm @ardaguclu btw, it is better to use git revert for posterity

You are right, that would be better. Next time, I'll use it :) and thanks for tagging.

ardaguclu commented 1 week ago

/test e2e-agnostic-ovn-cmd

ardaguclu commented 1 week ago

No failure of the enabled tests, but anyway it is better to retest one more time; /retest

zhouying7780 commented 1 week ago

/label qe-approved

openshift-ci-robot commented 1 week ago

@ardaguclu: This pull request references Jira Issue OCPBUGS-42532, which is valid.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.18.0) matches configured target version for branch (4.18.0) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @zhouying7780

In response to [this](https://github.com/openshift/origin/pull/29289): >Since https://github.com/openshift/openshift-apiserver/pull/458 has merged, we can revert https://github.com/openshift/origin/pull/29141 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Forigin). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
zhouying7780 commented 1 week ago

/label cherry-pick-approved

zhouying7780 commented 1 week ago

/cherry-pick-approved cancel

dgoodwin commented 1 week ago

/lgtm

openshift-ci[bot] commented 1 week ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ardaguclu, atiratree, dgoodwin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/origin/blob/master/OWNERS)~~ [dgoodwin] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 1 week ago

/retest-required

Remaining retests: 0 against base HEAD 3fd5f626eca7ac52862a5331d9bce18bd771fa7f and 2 for PR HEAD 27068bad070ed6cade81f1b65516ad69538625ac in total

openshift-ci-robot commented 1 week ago

/retest-required

Remaining retests: 0 against base HEAD d86ecc914bdf36c69765ef592ddd2227d5960752 and 2 for PR HEAD 27068bad070ed6cade81f1b65516ad69538625ac in total

openshift-trt-bot commented 6 days ago

Job Failure Risk Analysis for sha: 27068bad070ed6cade81f1b65516ad69538625ac

Job Name Failure Risk
pull-ci-openshift-origin-master-e2e-aws-ovn-serial Medium
[bz-kube-apiserver][invariant] alert/KubeAPIErrorBudgetBurn should not be at or above info
This test has passed 96.36% of 55 runs on jobs ['periodic-ci-openshift-release-master-ci-4.18-e2e-aws-ovn-serial' 'periodic-ci-openshift-release-master-nightly-4.18-e2e-aws-ovn-serial'] in the last 14 days.

Open Bugs
SNO error rate for alert/KubeAPIErrorBudgetBurn should not be at or above info
openshift-ci-robot commented 6 days ago

/retest-required

Remaining retests: 0 against base HEAD 90f69547de0ebd6847a4a5ca0c8c44e02ea2d7ef and 1 for PR HEAD 27068bad070ed6cade81f1b65516ad69538625ac in total

openshift-ci[bot] commented 6 days ago

@ardaguclu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-kube-apiserver-rollout 27068bad070ed6cade81f1b65516ad69538625ac link false /test e2e-aws-ovn-kube-apiserver-rollout
ci/prow/okd-scos-e2e-aws-ovn 27068bad070ed6cade81f1b65516ad69538625ac link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-aws-ovn-single-node-upgrade 27068bad070ed6cade81f1b65516ad69538625ac link false /test e2e-aws-ovn-single-node-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci-robot commented 6 days ago

/retest-required

Remaining retests: 0 against base HEAD 92addf53603e9465d0930b146409818fefe3c14e and 0 for PR HEAD 27068bad070ed6cade81f1b65516ad69538625ac in total

openshift-ci-robot commented 6 days ago

/retest-required

Remaining retests: 0 against base HEAD f355db75374b0ce5f50facee94fb989478876a66 and 2 for PR HEAD 27068bad070ed6cade81f1b65516ad69538625ac in total

openshift-ci-robot commented 6 days ago

@ardaguclu: Jira Issue OCPBUGS-42532: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-42532 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/origin/pull/29289): >Since https://github.com/openshift/openshift-apiserver/pull/458 has merged, we can revert https://github.com/openshift/origin/pull/29141 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Forigin). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-bot commented 6 days ago

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-tests This PR has been included in build openshift-enterprise-tests-container-v4.18.0-202411160307.p0.g2ae2adf.assembly.stream.el9. All builds following this will include this PR.

openshift-bot commented 6 days ago

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-tests This PR has been included in build openshift-enterprise-tests-container-v4.19.0-202411160307.p0.g2ae2adf.assembly.stream.el9. All builds following this will include this PR.