openshift / origin

Conformance test suite for OpenShift
http://www.openshift.org
Apache License 2.0
8.49k stars 4.7k forks source link

OCPBUGS-44381: ovn-k, udn crd e2e: Fix status report consumer assertion #29291

Closed trozet closed 1 week ago

trozet commented 1 week ago

Following the incoming changes of the CUDN controller, the assertion on the UDN status is no longer valid.

Fix the assertion with the expected condition message.

openshift-ci[bot] commented 1 week ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maiqueb, trozet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[test/extended/networking/OWNERS](https://github.com/openshift/origin/blob/master/test/extended/networking/OWNERS)~~ [trozet] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
stbenjam commented 1 week ago

/override ci/prow/e2e-aws-ovn-upgrade /override ci/prow/e2e-aws-ovn-single-node-serial /override ci/prow/e2e-openstack-ovn /override ci/prow/e2e-metal-ipi-ovn-ipv6 /override ci/prow/e2e-metal-ipi-ovn /override ci/prow/e2e-gcp-ovn /override ci/prow/e2e-gcp-csi /override ci/prow/okd-scos-e2e-aws-ovn /override ci/prow/e2e-metal-ipi-ovn-kube-apiserver-rollout /override ci/prow/e2e-gcp-ovn-upgrade /override ci/prow/e2e-gcp-ovn-rt-upgrade /override ci/prow/e2e-aws-ovn-single-node-upgrade /skip /retitle OCPBUGS-44381: ovn-k, udn crd e2e: Fix status report consumer assertion

Required to unblock https://github.com/openshift/ovn-kubernetes/pull/2345

openshift-ci-robot commented 1 week ago

@trozet: This pull request references Jira Issue OCPBUGS-44381, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/origin/pull/29291): >Following the incoming changes of the CUDN controller, the assertion on the UDN status is no longer valid. > >Fix the assertion with the expected condition message. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Forigin). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
stbenjam commented 1 week ago

/jira refresh

openshift-ci[bot] commented 1 week ago

@stbenjam: Overrode contexts on behalf of stbenjam: ci/prow/e2e-aws-ovn-single-node-serial, ci/prow/e2e-aws-ovn-single-node-upgrade, ci/prow/e2e-aws-ovn-upgrade, ci/prow/e2e-gcp-csi, ci/prow/e2e-gcp-ovn, ci/prow/e2e-gcp-ovn-rt-upgrade, ci/prow/e2e-gcp-ovn-upgrade, ci/prow/e2e-metal-ipi-ovn, ci/prow/e2e-metal-ipi-ovn-ipv6, ci/prow/e2e-metal-ipi-ovn-kube-apiserver-rollout, ci/prow/e2e-openstack-ovn, ci/prow/okd-scos-e2e-aws-ovn

In response to [this](https://github.com/openshift/origin/pull/29291#issuecomment-2474865725): >/override ci/prow/e2e-aws-ovn-upgrade >/override ci/prow/e2e-aws-ovn-single-node-serial >/override ci/prow/e2e-openstack-ovn >/override ci/prow/e2e-metal-ipi-ovn-ipv6 >/override ci/prow/e2e-metal-ipi-ovn >/override ci/prow/e2e-gcp-ovn >/override ci/prow/e2e-gcp-csi >/override ci/prow/okd-scos-e2e-aws-ovn >/override ci/prow/e2e-metal-ipi-ovn-kube-apiserver-rollout >/override ci/prow/e2e-gcp-ovn-upgrade >/override ci/prow/e2e-gcp-ovn-rt-upgrade >/override ci/prow/e2e-aws-ovn-single-node-upgrade >/skip >/retitle OCPBUGS-44381: ovn-k, udn crd e2e: Fix status report consumer assertion > >Required to unblock https://github.com/openshift/ovn-kubernetes/pull/2345 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-ci-robot commented 1 week ago

@stbenjam: This pull request references Jira Issue OCPBUGS-44381, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.18.0) matches configured target version for branch (4.18.0) * bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @anuragthehatter

In response to [this](https://github.com/openshift/origin/pull/29291#issuecomment-2474869398): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Forigin). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
stbenjam commented 1 week ago

/skip /override ci/prow/e2e-aws-ovn-microshift-serial /override ci/prow/e2e-aws-ovn-microshift

openshift-ci[bot] commented 1 week ago

@stbenjam: Overrode contexts on behalf of stbenjam: ci/prow/e2e-aws-ovn-microshift, ci/prow/e2e-aws-ovn-microshift-serial

In response to [this](https://github.com/openshift/origin/pull/29291#issuecomment-2474871221): >/skip >/override ci/prow/e2e-aws-ovn-microshift-serial >/override ci/prow/e2e-aws-ovn-microshift Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
stbenjam commented 1 week ago

/override ci/prow/e2e-aws-ovn-serial /override ci/prow/e2e-aws-ovn-fips /override ci/prow/e2e-aws-ovn-edge-zones

openshift-ci[bot] commented 1 week ago

@stbenjam: Overrode contexts on behalf of stbenjam: ci/prow/e2e-aws-ovn-edge-zones, ci/prow/e2e-aws-ovn-fips, ci/prow/e2e-aws-ovn-serial

In response to [this](https://github.com/openshift/origin/pull/29291#issuecomment-2474875264): >/override ci/prow/e2e-aws-ovn-serial >/override ci/prow/e2e-aws-ovn-fips >/override ci/prow/e2e-aws-ovn-edge-zones Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-ci-robot commented 1 week ago

@trozet: Jira Issue OCPBUGS-44381: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-44381 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/origin/pull/29291): >Following the incoming changes of the CUDN controller, the assertion on the UDN status is no longer valid. > >Fix the assertion with the expected condition message. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Forigin). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 1 week ago

@trozet: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-single-node 0f359d7996f9d8945e75d8a744edc2929c2bd04b link false /test e2e-aws-ovn-single-node
ci/prow/e2e-aws-csi 0f359d7996f9d8945e75d8a744edc2929c2bd04b link false /test e2e-aws-csi

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-bot commented 1 week ago

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-tests This PR has been included in build openshift-enterprise-tests-container-v4.19.0-202411140108.p0.g8e2e54e.assembly.stream.el9. All builds following this will include this PR.

jluhrsen commented 6 days ago

/cherry-pick release-4.17

openshift-cherrypick-robot commented 6 days ago

@jluhrsen: new pull request created: #29301

In response to [this](https://github.com/openshift/origin/pull/29291#issuecomment-2479794340): >/cherry-pick release-4.17 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.