search

openshift / origin

Conformance test suite for OpenShift
http://www.openshift.org
Apache License 2.0
8.49k stars 4.7k forks source link

External binary caching and code clean-up #29300

Open stbenjam opened 6 days ago

stbenjam commented 6 days ago

Adds a caching layer for external binary extraction so it's easier to re-run openshift-tests locally. There's a README with additional info in pkg/test/externalbinary/README.md.

This also reduces the complexity of cmd_runsuite, and encapsulates all image extraction code, so it can be used elsewhere more easily.

It does not yet move to the new interface with openshift-tests-extension, but makes it easier to do that later. This PR was already large enough by itself.

openshift-ci[bot] commented 6 days ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

stbenjam commented 6 days ago

See how much I broke

/test e2e-aws-ovn

stbenjam commented 3 days ago

/test e2e-aws-ovn

openshift-ci[bot] commented 3 days ago

@stbenjam: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-single-node-upgrade 6a127740dc56c01a7f79042f75b57a48d8df15e7 link false /test e2e-aws-ovn-single-node-upgrade
ci/prow/e2e-aws-ovn-kube-apiserver-rollout 6a127740dc56c01a7f79042f75b57a48d8df15e7 link false /test e2e-aws-ovn-kube-apiserver-rollout
ci/prow/e2e-metal-ipi-ovn-kube-apiserver-rollout 6a127740dc56c01a7f79042f75b57a48d8df15e7 link false /test e2e-metal-ipi-ovn-kube-apiserver-rollout
ci/prow/e2e-aws-ovn-cgroupsv2 6a127740dc56c01a7f79042f75b57a48d8df15e7 link false /test e2e-aws-ovn-cgroupsv2
ci/prow/e2e-aws-ovn-single-node-serial 6a127740dc56c01a7f79042f75b57a48d8df15e7 link false /test e2e-aws-ovn-single-node-serial
ci/prow/e2e-agnostic-ovn-cmd 6a127740dc56c01a7f79042f75b57a48d8df15e7 link false /test e2e-agnostic-ovn-cmd

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
jupierce commented 2 days ago

holding in case there is interest in the cache dir alternative. /lgtm /hold

openshift-ci[bot] commented 2 days ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jupierce, stbenjam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/origin/blob/master/OWNERS)~~ [stbenjam] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
stbenjam commented 2 days ago

/payload 4.18 nightly blocking

openshift-ci[bot] commented 2 days ago

@stbenjam: trigger 14 job(s) of type blocking for the nightly release of OCP 4.18

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/1502db70-a6cd-11ef-9171-b582f25d8074-0