openshift / origin

Conformance test suite for OpenShift
http://www.openshift.org
Apache License 2.0
8.49k stars 4.7k forks source link

Revert "NO-ISSUE: Add Capability and FeatureGate checks to OLMv1 tests" #29303

Closed xueqzhan closed 3 days ago

xueqzhan commented 3 days ago

Reverts https://github.com/openshift/origin/pull/29290 ; tracked by https://issues.redhat.com/browse/OCPBUGS-44662

Per OpenShift policy, we are reverting this breaking change to get CI and/or nightly payloads flowing again.

This change is breaking 4.18 nightly. First payload failure https://amd64.ocp.releases.ci.openshift.org/releasestream/4.18.0-0.nightly/release/4.18.0-0.nightly-2024-11-16-132904

See thread for more details: https://redhat-internal.slack.com/archives/C01CQA76KMX/p1731937499008099?thread_ts=1731522911.671799&cid=C01CQA76KMX

To unrevert this, revert this PR, and layer an additional separate commit on top that addresses the problem. Before merging the unrevert, please run these jobs on the PR and check the result of (job/X or job/X, test/Y tuple) to confirm the fix has corrected the problem:

/payload-job periodic-ci-openshift-release-master-ci-4.18-e2e-aws-ovn-techpreview-serial

CC: @tmshort @joelanford

openshift-ci-robot commented 3 days ago

@xueqzhan: This pull request explicitly references no jira issue.

In response to [this](https://github.com/openshift/origin/pull/29303): >TRT has unfortunately had to revert this breaking change to get CI and/or nightly payloads flowing again. > >The original PR was https://github.com/openshift/origin/pull/29290. > >To restore your change, create a new PR that reverts the revert and layers additional separate commit(s) on top that addresses the problem. > > >Contact information for TRT is available at https://source.redhat.com/groups/public/atomicopenshift/atomicopenshift_wiki/how_to_contact_the_technical_release_team. Please reach out if you need assistance in relanding your change or have feedback about this process. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Forigin). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
stbenjam commented 3 days ago

/lgtm

openshift-ci[bot] commented 3 days ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: stbenjam, xueqzhan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/origin/blob/master/OWNERS)~~ [stbenjam,xueqzhan] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
stbenjam commented 3 days ago

/override ci/prow/e2e-aws-ovn-serial /override ci/prow/e2e-aws-ovn-microshift /override ci/prow/e2e-metal-ipi-ovn /override ci/prow/e2e-aws-ovn-single-node /override ci/prow/e2e-gcp-ovn /override ci/prow/e2e-gcp-csi /override ci/prow/e2e-aws-ovn-edge-zones /override ci/prow/e2e-aws-csi /override ci/prow/e2e-agnostic-ovn-cmd /override ci/prow/e2e-metal-ipi-ovn-kube-apiserver-rollout /override ci/prow/e2e-metal-ipi-ovn-ipv6 /override ci/prow/e2e-aws-ovn-single-node-upgrade /override ci/prow/e2e-aws-ovn-cgroupsv2 /override ci/prow/e2e-openstack-ovn /override ci/prow/e2e-gcp-ovn-upgrade /override ci/prow/e2e-aws-ovn-upgrade /override ci/prow/e2e-aws-ovn-single-node-serial /override ci/prow/e2e-aws-ovn-microshift-serial /override ci/prow/e2e-aws-ovn-kube-apiserver-rollout /override ci/prow/e2e-aws-ovn-fips /override ci/prow/okd-scos-e2e-aws-ovn /override ci/prow/e2e-gcp-ovn-rt-upgrade /skip

openshift-ci[bot] commented 3 days ago

@stbenjam: Overrode contexts on behalf of stbenjam: ci/prow/e2e-agnostic-ovn-cmd, ci/prow/e2e-aws-csi, ci/prow/e2e-aws-ovn-cgroupsv2, ci/prow/e2e-aws-ovn-edge-zones, ci/prow/e2e-aws-ovn-fips, ci/prow/e2e-aws-ovn-kube-apiserver-rollout, ci/prow/e2e-aws-ovn-microshift, ci/prow/e2e-aws-ovn-microshift-serial, ci/prow/e2e-aws-ovn-serial, ci/prow/e2e-aws-ovn-single-node, ci/prow/e2e-aws-ovn-single-node-serial, ci/prow/e2e-aws-ovn-single-node-upgrade, ci/prow/e2e-aws-ovn-upgrade, ci/prow/e2e-gcp-csi, ci/prow/e2e-gcp-ovn, ci/prow/e2e-gcp-ovn-rt-upgrade, ci/prow/e2e-gcp-ovn-upgrade, ci/prow/e2e-metal-ipi-ovn, ci/prow/e2e-metal-ipi-ovn-ipv6, ci/prow/e2e-metal-ipi-ovn-kube-apiserver-rollout, ci/prow/e2e-openstack-ovn, ci/prow/okd-scos-e2e-aws-ovn

In response to [this](https://github.com/openshift/origin/pull/29303#issuecomment-2483264186): >/override ci/prow/e2e-aws-ovn-serial >/override ci/prow/e2e-aws-ovn-microshift >/override ci/prow/e2e-metal-ipi-ovn >/override ci/prow/e2e-aws-ovn-single-node >/override ci/prow/e2e-gcp-ovn >/override ci/prow/e2e-gcp-csi >/override ci/prow/e2e-aws-ovn-edge-zones >/override ci/prow/e2e-aws-csi >/override ci/prow/e2e-agnostic-ovn-cmd >/override ci/prow/e2e-metal-ipi-ovn-kube-apiserver-rollout >/override ci/prow/e2e-metal-ipi-ovn-ipv6 >/override ci/prow/e2e-aws-ovn-single-node-upgrade >/override ci/prow/e2e-aws-ovn-cgroupsv2 >/override ci/prow/e2e-openstack-ovn >/override ci/prow/e2e-gcp-ovn-upgrade >/override ci/prow/e2e-aws-ovn-upgrade >/override ci/prow/e2e-aws-ovn-single-node-serial >/override ci/prow/e2e-aws-ovn-microshift-serial >/override ci/prow/e2e-aws-ovn-kube-apiserver-rollout >/override ci/prow/e2e-aws-ovn-fips >/override ci/prow/okd-scos-e2e-aws-ovn >/override ci/prow/e2e-gcp-ovn-rt-upgrade >/skip Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
joelanford commented 3 days ago

/test e2e-gcp-ovn-techpreview

stbenjam commented 3 days ago

/override ci/prow/e2e-gcp-ovn-techpreview

We're returning the tests to a previously working state (actually all skipped) so don't think it's necessary

openshift-ci[bot] commented 3 days ago

@stbenjam: Overrode contexts on behalf of stbenjam: ci/prow/e2e-gcp-ovn-techpreview

In response to [this](https://github.com/openshift/origin/pull/29303#issuecomment-2483308239): >/override ci/prow/e2e-gcp-ovn-techpreview Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
stbenjam commented 3 days ago

/override ci/prow/e2e-metal-ipi-ovn-kube-apiserver-rollout

openshift-ci[bot] commented 3 days ago

@stbenjam: Overrode contexts on behalf of stbenjam: ci/prow/e2e-metal-ipi-ovn-kube-apiserver-rollout

In response to [this](https://github.com/openshift/origin/pull/29303#issuecomment-2483376999): >/override ci/prow/e2e-metal-ipi-ovn-kube-apiserver-rollout Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 3 days ago

@xueqzhan: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-bot commented 3 days ago

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-tests This PR has been included in build openshift-enterprise-tests-container-v4.19.0-202411181637.p0.g6fdaf6b.assembly.stream.el9. All builds following this will include this PR.