Closed smarterclayton closed 9 years ago
I think showing the full build pod name predated the names being derivable from the build config The image snippet is truncating to 6-7ish characters, so it's never making it to the image hash
Probably want the image field like we discussed as well
On Jun 22, 2015, at 8:36 AM, Jordan Liggitt notifications@github.com wrote:
I think showing the full build pod name predated the names being derivable from the build config The image snippet is truncating to 6-7ish characters, so it's never making it to the image hash
— Reply to this email directly or view it on GitHub.
Unfortunately, I don't see a build number property or annotation like we have for deployments. I'll have to figure it out from the end of the name and be careful about cloned builds (#3368).
We should probably create those annotations with labels and then make sure they get surfaced up. Rather you having to hack around it.
On Jun 22, 2015, at 3:08 PM, Sam Padgett notifications@github.com wrote:
Unfortunately, I don't see a build number property or annotation like we have for deployments. I'll have to figure it out from the end of the name and be careful about cloned builds (#3368).
— Reply to this email directly or view it on GitHub.
First pass at this. Right now I'm showing the build name only since I can't easily get the number.
Still looks busy to me. Wondering if we really need the labels (Image, Build, ...) or if the icons with alt text are enough. If we do keep the labels, it might look cleaner to left-align the values.
As an aside, it bugs me that the icon and text aren't aligned here:
I would say "ruby-sample-build #7
" as a link. Image should probably be "[<namespace if different>/]<name>:<id or tag name or latest>
" with something like "(from :<tag>)
" if you show the ID. Reason is that we want to focus on what you actually deployed right now (which is usually the ID, sometimes the tag) and then tell you where you came from (the tag) to clarify.
Agree they're aligned
Changes so far. Tooltip shows the unabbreviated image value on hover.
I've also updated the build status message:
Working on showing (from :tag)
.
heh, @smarterclayton's original comment got rendered strangely by github... link the entire build name + number should we keep the "running build" part unlinked? you can already click on it and see details in the sidebar
OK, I have from :tag
for the image and removed the link from the running build.
Looks awesome
eventually we want to break the components up and link them cleanly - this is a good step. I'm tempted to change the font / formatting of the image id like a git commit id, but that's a broader discussion
/cc @jwforres relevant to the overview changes we've talked about
current state of things
With a few more changes as part of overview rework:
The pod template section is repeating a lot of redundant info redundantly. Some things: