openshift / origin

Conformance test suite for OpenShift
http://www.openshift.org
Apache License 2.0
8.47k stars 4.69k forks source link

Overview route warnings, but no warnings on routes page #7720

Closed spadgett closed 8 years ago

spadgett commented 8 years ago

I get a warning about routes on the overview page ...

openshift_web_console

... but no routes have a warning on the routes page.

openshift_web_console

@jwforres

spadgett commented 8 years ago

I stepped through RoutesService.getRouteWarning, and warnings comes back empty. Yet we still show the message on the overview.

Self-assigning since I have an environment to reproduce.

spadgett commented 8 years ago

I see the problem. routeWarningsByService[serviceId] has this content

 {"hello-openshift-localhost-dev":[],"route-edge":[]}

But this is our ng-if condition

(routeWarningsByService[serviceId] | hashSize) > 0 && otherRoutes
spadgett commented 8 years ago

No route shows up on the overview as well if there are multiple routes and none is custom, TLS, or admitted.

spadgett commented 8 years ago

RoutesService.getPreferredDisplayRoute also does not choose the TLS route when everything else equal.