openshift / origin

Conformance test suite for OpenShift
http://www.openshift.org
Apache License 2.0
8.49k stars 4.7k forks source link

flake TestSAAsOAuthClient #8955

Closed deads2k closed 8 years ago

deads2k commented 8 years ago

has no tokens allowed as oauth client secrets; set serviceaccounts.openshift.io/oauth-client-secret=true on a token secret

--- FAIL: TestSAAsOAuthClient (4.35s)
    sa_oauthclient_test.go:181: didn't get an unauthorized:
         HTTP/1.1 400 Bad Request
        Content-Length: 178
        Cache-Control: no-cache, no-store, max-age=0, must-revalidate
        Content-Type: application/json
        Date: Fri, 20 May 2016 03:23:19 GMT
        Expires: Fri, 01 Jan 1990 00:00:00 GMT
        Pragma: no-cache

        {"error":"server_error","error_description":"The authorization server encountered an unexpected condition that prevented it from fulfilling the request.","state":"opaque-scope"}
deads2k commented 8 years ago

The good news is that is fails safe. The bad news is that we're racing in etcd and the API server somehow. I'm not sure how a watch can be faster than a get, but its the only explanation I've got.