Replace fsouza/go-dockerclient with docker/engine-api

openshift / origin

Conformance test suite for OpenShift

http://www.openshift.org

Apache License 2.0

8.49k stars 4.7k forks source link

Replace fsouza/go-dockerclient with docker/engine-api #9320

Closed mfojtik closed 8 years ago

mfojtik commented 8 years ago

Kubernetes already moved to use the docker/engine-api, we should follow that as well. The rebase will have wrapper that allow us to transition to new Docker client without breaking stuff.

We will also need to switch S2I to use engine-api.

mfojtik commented 8 years ago

@bparees is this something devexp will want to own? I think builds is the biggest user of go-dockerclient.

liggitt commented 8 years ago

Related items from rebase:

engine-api supports token auth as well
re-enable new-app integration test
remove wrapper holding go-dockerclient and engine-api objects
fix DOCKER_HOST env workaround on OS X

bparees commented 8 years ago

i guess we can drive it. don't hold your breath :)

gabemontero commented 8 years ago

Per confirmation with @bparees, closing this out in favor of this trello card