openshift / os

90 stars 107 forks source link

Stop enabling `afterburn-hostname.service` on GCP #1432

Open jlebon opened 9 months ago

jlebon commented 9 months ago

Right now, RHCOS is carrying a patch for Afterburn to have it write to /etc/hostname (basically https://github.com/coreos/afterburn/pull/512).

There's a lot of backstory on this also in https://github.com/coreos/afterburn/issues/509. But IIUC, now that NM correctly shortens DHCP hostnames that are too long, we can rely on hostname setting via DHCP again and stop carrying that patch.

A big change here of course is that we'd no longer physically write /etc/hostname from the initramfs. Need to verify this doesn't break things. (Though presumably this works in OKD + FCOS today, where we don't have that patch.)

openshift-bot commented 6 months ago

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

jlebon commented 6 months ago

/remove-lifecycle stale

openshift-bot commented 3 months ago

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

jlebon commented 3 months ago

/remove-lifecycle stale

openshift-bot commented 3 days ago

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

jlebon commented 2 days ago

/remove-lifecycle stale