openshift / os

89 stars 105 forks source link

OCPBUGS-32927: Bump OVS version to 3.3. #1495

Closed igsilya closed 1 month ago

igsilya commented 2 months ago

Open vSwitch 3.3 is going to be a new LTS version. It contains performance improvements and features required for future releases of OVN.

ovn-kubernetes container image is moving to this version as well, and it's better to keep them in sync.

ovn-kubernetes counterpart: https://github.com/openshift/ovn-kubernetes/pull/2142

openshift-ci-robot commented 2 months ago

@igsilya: This pull request references Jira Issue OCPBUGS-32927, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.16.0) matches configured target version for branch (4.16.0) * bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @mike-nguyen

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/os/pull/1495): >Open vSwitch 3.3 is going to be a new LTS version. It contains performance improvements and features required for future releases of OVN. > >ovn-kubernetes container image is moving to this version as well, and it's better to keep them in sync. > >ovn-kubernetes counterpart: https://github.com/openshift/ovn-kubernetes/pull/2142 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fos). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 2 months ago

Hi @igsilya. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
dceara commented 2 months ago

/ok-to-test

jlebon commented 2 months ago

Patch itself LGTM. /approve

Will let @dcbw sanity-check it since historically he's been the one bumping OVS.

/assign dcbw

igsilya commented 2 months ago

@jlebon Hi. I don't think Dan will be checking this PR. See the email.

tssurya commented 2 months ago

/hold till ovs container bump lands

jlebon commented 2 months ago

/lgtm

Feel free to drop the hold when ready.

openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: igsilya, jlebon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/os/blob/master/OWNERS)~~ [jlebon] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
igsilya commented 1 month ago

All the container changes have landed last week. Did another round of conformance tests on a manually upgraded cluster with this change and it looked good.

/remove-hold

openshift-ci-robot commented 1 month ago

/retest-required

Remaining retests: 0 against base HEAD d682302da679dc69e7d65d73f17b9c236819ee1e and 2 for PR HEAD 92e4ef229f340e7f68bd4b1fbd98f0addfe83663 in total

igsilya commented 1 month ago

/retest-required

igsilya commented 1 month ago
error: Installing packages: Failed to parse selector: nss-altfiles
failed to execute cmd-fetch: exit status 1

Not sure why this is failing (didn't fail before).

@jlebon do you have ideas on why this can be?

igsilya commented 1 month ago

Looks like the issue is affecting other PRs as well, i.e. not related to this one.

jlebon commented 1 month ago
error: Installing packages: Failed to parse selector: nss-altfiles
failed to execute cmd-fetch: exit status 1

I hit this locally too and then updated my repo files to use the 9.4 GA repos instead of beta. I suspect the in-cluster mirrors might still have beta content.

travier commented 1 month ago

CI fixes in https://github.com/openshift/release/pull/51750

igsilya commented 1 month ago

/retest-required

(I wonder how fast changes propagate.)

openshift-ci[bot] commented 1 month ago

@igsilya: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci-robot commented 1 month ago

@igsilya: Jira Issue OCPBUGS-32927: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-32927 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/os/pull/1495): >Open vSwitch 3.3 is going to be a new LTS version. It contains performance improvements and features required for future releases of OVN. > >ovn-kubernetes container image is moving to this version as well, and it's better to keep them in sync. > >ovn-kubernetes counterpart: https://github.com/openshift/ovn-kubernetes/pull/2142 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fos). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.