search

openshift / os

89 stars 105 forks source link

NO-JIRA: faq: clean up dynamic secondary device example #1509

Closed jlebon closed 1 month ago

jlebon commented 1 month ago

We don't need to use an overcomplicated env unit dropin here. We can just label the filesystem with a stable name and use that to refer to the device in the mount unit.

Related: https://github.com/coreos/fedora-coreos-tracker/issues/1732

travier commented 1 month ago

/lgtm

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jbtrystram, jlebon, travier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/os/blob/master/OWNERS)~~ [jbtrystram,jlebon,travier] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
jlebon commented 1 month ago

/refresh

openshift-ci-robot commented 1 month ago

@jlebon: This pull request explicitly references no jira issue.

In response to [this](https://github.com/openshift/os/pull/1509): >We don't need to use an overcomplicated env unit dropin here. We can just label the filesystem with a stable name and use that to refer to the device in the mount unit. > >Related: https://github.com/coreos/fedora-coreos-tracker/issues/1732 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fos). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.