search

openshift / os

89 stars 105 forks source link

COS-2769: bump version to 4.17 #1511

Closed mike-nguyen closed 1 month ago

mike-nguyen commented 1 month ago

4.16 branched so bump the version in main development to 4.17.

openshift-ci-robot commented 1 month ago

@mike-nguyen: This pull request references COS-2769 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

In response to [this](https://github.com/openshift/os/pull/1511): >4.16 branched so bump the version in main development to 4.17. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fos). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
mike-nguyen commented 1 month ago

/hold until ART plashet gets added to internal repos. Reviews welcomed still.

jlebon commented 1 month ago

There are a few more places that need to be updated. Try a git grep 4\\.16.

mike-nguyen commented 1 month ago

There are a few more places that need to be updated. Try a git grep 4\\.16.

Thanks there were a lot more! I will update the branching doc with this PR as a reference.

mike-nguyen commented 1 month ago

/hold cancel ART repos are are added and merged.

mike-nguyen commented 1 month ago

/retest

jlebon commented 1 month ago

/approve /lgtm

openshift-ci-robot commented 1 month ago

/retest-required

Remaining retests: 0 against base HEAD 8e6ac83347763adc87103b48596eb4bd8f42cb72 and 2 for PR HEAD 55abc92addd41a80aa3ffce712ca5cdd067f344c in total

openshift-ci-robot commented 1 month ago

/retest-required

Remaining retests: 0 against base HEAD 353d297e733c75a9269c06652c6c9a9bbd5cb395 and 1 for PR HEAD 55abc92addd41a80aa3ffce712ca5cdd067f344c in total

jlebon commented 1 month ago

rpm-md repo 'rhel-9.4-baseos'; generated: 2024-05-02T07:02:38Z solvables: 0 rpm-md repo 'rhel-9.4-appstream'; generated: 2024-05-02T07:16:36Z solvables: 0

Huh, the repos are empty. Ahh, I think we need https://github.com/openshift/release/pull/52325 at least.

jlebon commented 1 month ago

/retest

mike-nguyen commented 1 month ago

there are rhaos packages are old in the ART plashet causing kola test failures

Also seeing this in the prow/validate job which I've never seen before. Did something change or is something more strict than before?

+ git clone /go/src/github.com/openshift/os os
Cloning into 'os'...
fatal: detected dubious ownership in repository at '/go/src/github.com/openshift/os/.git'
To add an exception for this directory, call:

    git config --global --add safe.directory /go/src/github.com/openshift/os/.git
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.
{"component":"entrypoint","error":"wrapped process failed: exit status 128","file":"sigs.k8s.io/prow/pkg/entrypoint/run.go:84","func":"sigs.k8s.io/prow/pkg/entrypoint.Options.internalRun","level":"error","msg":"Error executing test process","severity":"error","time":"2024-05-22T01:06:47Z"} 
INFO[2024-05-22T01:06:49Z] Ran for 2m56s                                
ERRO[2024-05-22T01:06:49Z] Some steps failed:                           
ERRO[2024-05-22T01:06:49Z] 
  * could not run steps: step validate failed: test "validate" failed: could not watch pod: the pod ci-op-7tttzwgt/validate failed after 52s (failed containers: test): ContainerFailed one or more containers exited

Container test exited with code 128, reason Error
jlebon commented 1 month ago

Do you have a ticket already for the rebuilds necessary? We could also temporarily denylist it.

Also seeing this in the prow/validate job which I've never seen before. Did something change or is something more strict than before?

Added another commit for that one!

mike-nguyen commented 1 month ago

Do you have a ticket already for the rebuilds necessary? We could also temporarily denylist it.

Also seeing this in the prow/validate job which I've never seen before. Did something change or is something more strict than before?

Added another commit for that one!

@haircommander helped us by building conmon and cri-o with the correct brew tags. We are still waiting for conmon-rs which is usually built by @jnovy

jlebon commented 1 month ago

/retest

mike-nguyen commented 1 month ago

The cri-o rebuild is blocked on RHEL-35883. We may need to skip the test for now.

travier commented 1 month ago 
Running test: iso-offline-install.bios
FAIL: iso-offline-install.bios (10m0.002s)
    timed out after 10m0s
Running test: iso-offline-install.mpath.bios
FAIL: iso-offline-install.mpath.bios (10m0.004s)
    timed out after 10m0s
Running test: iso-offline-install-fromram.4k.uefi
FAIL: iso-offline-install-fromram.4k.uefi (10m0.001s)
    timed out after 10m0s
Running test: miniso-install.bios
FAIL: miniso-install.bios (10m0.002s)
    timed out after 10m0s
Running test: miniso-install.nm.bios
FAIL: miniso-install.nm.bios (10m0.007s)
    timed out after 10m0s
Running test: miniso-install.4k.uefi
FAIL: miniso-install.4k.uefi (10m0s)
    timed out after 10m0s
Running test: miniso-install.4k.nm.uefi
FAIL: miniso-install.4k.nm.uefi (10m0.001s)
    timed out after 10m0s
Running test: pxe-offline-install.bios
FAIL: pxe-offline-install.bios (10m0s)
    timed out after 10m0s
Running test: pxe-offline-install.4k.uefi
FAIL: pxe-offline-install.4k.uefi (10m0.002s)
    timed out after 10m0s
Running test: pxe-online-install.bios
FAIL: pxe-online-install.bios (10m0.005s)
    timed out after 10m0s
Running test: pxe-online-install.4k.uefi
FAIL: pxe-online-install.4k.uefi (10m0.008s)
    timed out after 10m0s
Error: harness: test suite failed

Hum, why is SCOS running the UEFI tests? 🤔

Edit: Nevermind, it's EFI only, not Secure Boot.

travier commented 1 month ago

/hold

travier commented 1 month ago

/retest

jlebon commented 1 month ago

/retest

jlebon commented 1 month ago

Updated this now to pin selinux-policy due to https://github.com/openshift/os/issues/1514.

jlebon commented 1 month ago

/hold cancel

jlebon commented 1 month ago

/retest

openshift-ci[bot] commented 1 month ago

@mike-nguyen: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
mike-nguyen commented 1 month ago

/lgtm jonathan's changes

jlebon commented 1 month ago

And Mike's changes /lgtm

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jlebon, mike-nguyen, travier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/os/blob/master/OWNERS)~~ [jlebon,mike-nguyen,travier] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment