openshift / os

89 stars 105 forks source link

COS-2613: [release-4.14]: kola: fix rhaos-pkgs-match-openshift #1515

Closed c4rt0 closed 3 weeks ago

c4rt0 commented 1 month ago

See: https://github.com/openshift/os/issues/1427

Co-authored-by: Clement Verna cverna@users.noreply.github.com (cherry picked from commit 219d60f52eece0b09339d0f8568d06cf2553a575)

ci/prow-entrypoint: tell git repo under /src is safe That directory is part of the image and so not owned by us. Likely the base image used for the src container was updated recently to include newer git.

(cherry picked from commit https://github.com/openshift/os/commit/630d3f3d9c530c238e03c93210598101eafca266)

openshift-ci-robot commented 1 month ago

@c4rt0: This pull request references COS-2613 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

In response to [this](https://github.com/openshift/os/pull/1515): >Due to an Error in CI of an automated cherry-pick in https://github.com/openshift/os/pull/1512, where `ci/prow/rhcos-92-build-test-qemu` and ` >ci/prow/validate` failed, this PR has been created as suggested to avoid the mentioned issues. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fos). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 1 month ago

@c4rt0: This pull request references COS-2613 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.14.z" version, but no target version was set.

In response to [this](https://github.com/openshift/os/pull/1515): >Due to an Error in CI of an automated cherry-pick in https://github.com/openshift/os/pull/1512, where `ci/prow/rhcos-92-build-test-qemu` and ` >ci/prow/validate` failed, this PR has been created as suggested to avoid the mentioned issues. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fos). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 1 month ago

@c4rt0: This pull request references COS-2613 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.14.z" version, but no target version was set.

In response to [this](https://github.com/openshift/os/pull/1515): >See: https://github.com/openshift/os/issues/1427 > >Co-authored-by: Clement Verna >(cherry picked from commit 219d60f52eece0b09339d0f8568d06cf2553a575) Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fos). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
jlebon commented 1 month ago

Cherry-picking https://github.com/openshift/os/commit/630d3f3d9c530c238e03c93210598101eafca266 here also should fix the CI failure.

openshift-ci-robot commented 1 month ago

@c4rt0: This pull request references COS-2613 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.14.z" version, but no target version was set.

In response to [this](https://github.com/openshift/os/pull/1515): >See: https://github.com/openshift/os/issues/1427 > >Co-authored-by: Clement Verna >(cherry picked from commit 219d60f52eece0b09339d0f8568d06cf2553a575) > >ci/prow-entrypoint: tell git repo under /src is safe >That directory is part of the image and so not owned by us. Likely the >base image used for the src container was updated recently to include >newer git. > >(cherry picked from commit https://github.com/openshift/os/commit/630d3f3d9c530c238e03c93210598101eafca266) Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fos). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
c4rt0 commented 1 month ago

Cherry-picking 630d3f3 here also should fix the CI failure.

Will this also work with 4.13 and 4.12?

mike-nguyen commented 1 month ago

Cherry-picking 630d3f3 here also should fix the CI failure.

Will this also work with 4.13 and 4.12?

@c4rt0 From quick glance it looks like it will work

mike-nguyen commented 1 month ago

There seems to be #1512 that is also targeting 4.14 (at least in the title). Which one are you actively working on?

mike-nguyen commented 1 month ago

/label backport-risk-assessed /label cherry-pick-approved

c4rt0 commented 1 month ago

There seems to be #1512 that is also targeting 4.14 (at least in the title). Which one are you actively working on?

That's unfortunately correct. I am wondering if I can/should/ close the automatic cherry-pick on behalf of the manual one. See: https://github.com/openshift/os/pull/1456#issuecomment-2133798079

c4rt0 commented 4 weeks ago

/retest

c4rt0 commented 4 weeks ago

/retest

c4rt0 commented 4 weeks ago

The outdated build of conmon-rs has been updated for 4.14. Tests should now pass: https://brewweb.engineering.redhat.com/brew/buildinfo?buildID=3097766

c4rt0 commented 4 weeks ago

/retest

c4rt0 commented 4 weeks ago

/retest

openshift-ci[bot] commented 4 weeks ago

@c4rt0: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/rhcos-9-build-test-qemu acae85b58e0c042ab89cdf512c243f55e0a2bfc3 link true /test rhcos-9-build-test-qemu
ci/prow/scos-9-build-test-metal acae85b58e0c042ab89cdf512c243f55e0a2bfc3 link true /test scos-9-build-test-metal
ci/prow/images acae85b58e0c042ab89cdf512c243f55e0a2bfc3 link true /test images
ci/prow/rhcos-9-build-test-metal acae85b58e0c042ab89cdf512c243f55e0a2bfc3 link true /test rhcos-9-build-test-metal
ci/prow/validate acae85b58e0c042ab89cdf512c243f55e0a2bfc3 link true /test validate
ci/prow/scos-9-build-test-qemu acae85b58e0c042ab89cdf512c243f55e0a2bfc3 link true /test scos-9-build-test-qemu

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
c4rt0 commented 3 weeks ago

/retest

travier commented 3 weeks ago

/lgtm

openshift-ci[bot] commented 3 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: c4rt0, travier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/os/blob/release-4.14/OWNERS)~~ [c4rt0,travier] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
c4rt0 commented 3 weeks ago

/jira refresh

openshift-ci-robot commented 3 weeks ago

@c4rt0: This pull request references COS-2613 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.14.z" version, but no target version was set.

In response to [this](https://github.com/openshift/os/pull/1515#issuecomment-2152804571): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fos). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
c4rt0 commented 3 weeks ago

Awesome, that worked. Thanks @jlebon.