search

openshift / os

89 stars 105 forks source link

OCPBUGS-33124: coreos-cryptfs: drop growpart call #1522

Closed madhu-pillai closed 1 week ago

madhu-pillai commented 3 weeks ago

It was weird how we would growpart on every boot in the old-style LUKS code path. In comparison, on new installs nowadays, we only growpart once on first boot and never again. Since we don't support new installs that use the old-style LUKS scheme anymore, let's just drop the growpart call.

This also fixes some issues we've been seeing on s390x systems using DASD devices where it would make the device temporarily unaccessible due to sfdisk not understanding DASD partitioning, and some locking that growpart does that lingers and breaks the following blockdev call.

Fixes: https://issues.redhat.com/browse/OCPBUGS-33124

openshift-ci-robot commented 3 weeks ago

@madhu-pillai: This pull request references Jira Issue OCPBUGS-33124, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/os/pull/1522): >4.12-4.13 upgrade fails due to missing partition `/dev/dasda2`. Investigation proves that disabling the `growpart` causing the partition disappears. > >https://issues.redhat.com/browse/OCPBUGS-33124?filter=-1 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fos). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
cverna commented 2 weeks ago

/retest

openshift-ci-robot commented 2 weeks ago

@madhu-pillai: This pull request references Jira Issue OCPBUGS-33124, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift/os/pull/1522): >It was weird how we would growpart *on every boot* in the old-style LUKS >code path. In comparison, on new installs nowadays, we only growpart >once on first boot and never again. Since we don't support new installs >that use the old-style LUKS scheme anymore, let's just drop the growpart >call. > >This also fixes some issues we've been seeing on s390x systems using >DASD devices where it would make the device temporarily unaccessible >due to sfdisk not understanding DASD partitioning, and some locking that >growpart does that lingers and breaks the following `blockdev` call. > >Fixes: https://issues.redhat.com/browse/OCPBUGS-33124 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fos). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
jlebon commented 2 weeks ago

Pushed an update here. Removed more dead code and expanded on the commit message.

/lgtm

Fixed up the linked Jira card.

/jira refresh

That said, CI will likely fail here due to https://github.com/openshift/os/issues/1523 but we can force it in since it doesn't cover this path at all. As a final sanity-check, @madhu-pillai can you test this latest version manually?

openshift-ci-robot commented 2 weeks ago

@jlebon: This pull request references Jira Issue OCPBUGS-33124, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/os/pull/1522#issuecomment-2176206988): >Pushed an update here. Removed more dead code and expanded on the commit message. > >/lgtm > >Fixed up the linked Jira card. > >/jira refresh > >That said, CI will likely fail here due to https://github.com/openshift/os/issues/1523 but we can force it in since it doesn't cover this path at all. As a final sanity-check, @madhu-pillai can you test this latest version manually? Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fos). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
jlebon commented 2 weeks ago

/jira refresh

openshift-ci-robot commented 2 weeks ago

@jlebon: This pull request references Jira Issue OCPBUGS-33124, which is valid.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.17.0) matches configured target version for branch (4.17.0) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @mike-nguyen

In response to [this](https://github.com/openshift/os/pull/1522#issuecomment-2176209165): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fos). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 2 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jlebon, madhu-pillai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/os/blob/master/OWNERS)~~ [jlebon,madhu-pillai] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 2 weeks ago

/retest-required

Remaining retests: 0 against base HEAD c895761f289a79b0f76bc00955620e93dc92c8c5 and 2 for PR HEAD 12d62d4d20b93bbe5ecda60153a9c3cd4da1a0cc in total

jlebon commented 2 weeks ago

As expected, CI is failing on https://github.com/openshift/os/issues/1523.

/override ci/prow/rhcos-9-build-test-qemu /override ci/prow/scos-9-build-test-qemu

That said, adding a hold for

As a final sanity-check, @madhu-pillai can you test this latest version manually?

Feel free to drop the hold (with /hold cancel) once you did that.

jlebon commented 2 weeks ago

/hold

openshift-ci[bot] commented 2 weeks ago

@jlebon: Overrode contexts on behalf of jlebon: ci/prow/rhcos-9-build-test-qemu, ci/prow/scos-9-build-test-qemu

In response to [this](https://github.com/openshift/os/pull/1522#issuecomment-2176983735): >As expected, CI is failing on https://github.com/openshift/os/issues/1523. > >/override ci/prow/rhcos-9-build-test-qemu >/override ci/prow/scos-9-build-test-qemu > >That said, adding a hold for > >> As a final sanity-check, @madhu-pillai can you test this latest version manually? > >Feel free to drop the hold (with `/hold cancel`) once you did that. Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
madhu-pillai commented 1 week ago

hi @jlebon, I have tested it. I can reproduce the issue from 4.5 -> 4.12 -> 4.17 After applying the fix , I can upgrade 4.5 -> 4.12 -> 4.17

 [core@master-1 ~]$ sudo rpm-ostree status
State: idle
Deployments:
* 573f47ef426ff0687c28669ecc720dfc483a8a3f5962eb4de6b62237b2982938
                  Version: 412.90.202301101512-0 (2023-01-10T15:44:38Z)

  658da8df8993a58836ba73eff84360fa6ccd61bb23b4b4f1b89048200992e0df
                  Version: 45.82.202007101157-0 (2020-07-10T12:05:50Z)

[core@master-1 ~]$ sudo rpm-ostree status
State: idle
Deployments:
● ostree-unverified-image:oci-archive:/srv/rhcos-417.94.202406200502-0-ostree.s390x.ociarchive
                   Digest: sha256:4c578e83be70c60e372e8c76108f38e8e30067a0d195298aad2df71d6b28bab3
                  Version: 417.94.202406200502-0 (2024-06-20T05:24:17Z)

  573f47ef426ff0687c28669ecc720dfc483a8a3f5962eb4de6b62237b2982938
                  Version: 412.90.202301101512-0 (2023-01-10T15:44:38Z)
madhu-pillai commented 1 week ago

/hold cancel

openshift-ci-robot commented 1 week ago

/retest-required

Remaining retests: 0 against base HEAD dee91eaab229f343c12bf3310325f21c2314d59a and 1 for PR HEAD 12d62d4d20b93bbe5ecda60153a9c3cd4da1a0cc in total

cverna commented 1 week ago

/retest

jlebon commented 1 week ago

Nice, thanks for testing!

As expected, CI is failing on https://github.com/openshift/os/issues/1523. Let's just get this in to start the backport process.

/override ci/prow/rhcos-9-build-test-qemu /override ci/prow/scos-9-build-test-qemu

openshift-ci[bot] commented 1 week ago

@jlebon: Overrode contexts on behalf of jlebon: ci/prow/rhcos-9-build-test-qemu, ci/prow/scos-9-build-test-qemu

In response to [this](https://github.com/openshift/os/pull/1522#issuecomment-2180637347): >Nice, thanks for testing! > >As expected, CI is failing on https://github.com/openshift/os/issues/1523. Let's just get this in to start the backport process. > >/override ci/prow/rhcos-9-build-test-qemu >/override ci/prow/scos-9-build-test-qemu Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-ci-robot commented 1 week ago

@madhu-pillai: Jira Issue OCPBUGS-33124: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-33124 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/os/pull/1522): >It was weird how we would growpart *on every boot* in the old-style LUKS >code path. In comparison, on new installs nowadays, we only growpart >once on first boot and never again. Since we don't support new installs >that use the old-style LUKS scheme anymore, let's just drop the growpart >call. > >This also fixes some issues we've been seeing on s390x systems using >DASD devices where it would make the device temporarily unaccessible >due to sfdisk not understanding DASD partitioning, and some locking that >growpart does that lingers and breaks the following `blockdev` call. > >Fixes: https://issues.redhat.com/browse/OCPBUGS-33124 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fos). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 1 week ago

@madhu-pillai: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
madhu-pillai commented 1 week ago

/cherrypick release-4.16

openshift-cherrypick-robot commented 1 week ago

@madhu-pillai: new pull request created: #1534

In response to [this](https://github.com/openshift/os/pull/1522#issuecomment-2186576751): >/cherrypick release-4.16 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
madhu-pillai commented 1 week ago

/cherrypick release-4.15

openshift-cherrypick-robot commented 1 week ago

@madhu-pillai: new pull request created: #1535

In response to [this](https://github.com/openshift/os/pull/1522#issuecomment-2186877821): >/cherrypick release-4.15 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
madhu-pillai commented 1 week ago

/cherrypick release-4.14

madhu-pillai commented 1 week ago

/cherrypick release-4.13

openshift-cherrypick-robot commented 1 week ago

@madhu-pillai: new pull request created: #1536

In response to [this](https://github.com/openshift/os/pull/1522#issuecomment-2186898652): >/cherrypick release-4.14 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-cherrypick-robot commented 1 week ago

@madhu-pillai: new pull request created: #1537

In response to [this](https://github.com/openshift/os/pull/1522#issuecomment-2186899265): >/cherrypick release-4.13 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.