search

openshift / os

89 stars 107 forks source link

OKD-220: Update c9s.repo to install cri-o 1.29.5 #1541

Closed aleskandro closed 2 months ago

aleskandro commented 3 months ago

Updating the repo to install the latest crio 1.29 for 4.16. the 4.17 repo is not available yet. This should be backported to release-4.16

/cc @travier

aleskandro commented 3 months ago

/cherry-pick release-4.16

openshift-cherrypick-robot commented 3 months ago

@aleskandro: once the present PR merges, I will cherry-pick it on top of release-4.16 in a new PR and assign it to you.

In response to [this](https://github.com/openshift/os/pull/1541#issuecomment-2203082776): >/cherry-pick release-4.16 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-ci-robot commented 3 months ago

@aleskandro: This pull request references OKD-220 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.17.0" version, but no target version was set.

In response to [this](https://github.com/openshift/os/pull/1541): >Updating the repo to install the latest crio 1.29 for 4.16. the 4.17 repo is not available yet. This should be backported to release-4.16 > >/cc @travier > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fos). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
travier commented 3 months ago

We should not backport OKD-SCOS changes to branched releases. Everything should be built from the master branch.

travier commented 3 months ago

Change LGTM but no backport. /lgtm

openshift-ci[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aleskandro, travier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/os/blob/master/OWNERS)~~ [travier] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 3 months ago

/retest-required

Remaining retests: 0 against base HEAD 2467e5e2029dd5e387a8e92ac3b8555f56471130 and 2 for PR HEAD 71f0c6bab0d5ceb58322994a9b45cd68f3d578c0 in total

travier commented 3 months ago

/retest

aleskandro commented 2 months ago

One failure is about https://github.com/openshift/os/issues/1540

aleskandro commented 2 months ago 
        harness.go:1823: mach.Start() failed: machine "fdb74dc7-2401-42d2-832a-99d4eff463f5" failed basic checks: detected failed or stuck systemd units: some systemd units failed: systemd-network-generator.service; <nil>
=== RUN   rpmostree.upgrade-rollback/rollback
--- PASS: rpmostree.upgrade-rollback (135.24s)
    --- PASS: rpmostree.upgrade-rollback/upgrade (53.24s)
    --- PASS: rpmostree.upgrade-rollback/rollback (41.65s)
--- PASS: ext.config.shared.networking.nmstate.state (76.11s)
--- PASS: rhcos.network.init-interfaces-test (176.85s)
--- PASS: coreos.ignition.failure (30.27s)
--- FAIL: ext.config.shared.networking.prefer-ignition-networking (41.61s)
        harness.go:1823: mach.Start() failed: machine "ccc3eb72-4873-4f85-b223-4de8e8ca3528" failed basic checks: detected failed or stuck systemd units: some systemd units failed: systemd-network-generator.service; <nil> 
 --- PASS: ext.config.shared.ignition.resource.remote (74.59s)
--- FAIL: ext.config.shared.networking.bridge-static-via-kargs (42.05s)
        harness.go:1823: mach.Start() failed: machine "0e06ddb3-9af2-46fe-b3d5-bf94d496b894" failed basic checks: detected failed or stuck systemd units: some systemd units failed: systemd-network-generator.service; <nil>
--- PASS: ext.config.shared
aleskandro commented 2 months ago

/test scos-9-build-test-qemu

jlebon commented 2 months ago

Yeah, SCOS CI is broken right now as you see. I don't think we need to block on this.

/override ci/prow/scos-9-build-test-qemu

But as @travier said, this shouldn't be backported. It doesn't seem like there's a way to cancel a /cherrypick command, so we'll just have to close the PR it opens.

openshift-ci[bot] commented 2 months ago

@jlebon: Overrode contexts on behalf of jlebon: ci/prow/scos-9-build-test-qemu

In response to [this](https://github.com/openshift/os/pull/1541#issuecomment-2209377588): >Yeah, SCOS CI is broken right now as you see. I don't think we need to block on this. > >/override ci/prow/scos-9-build-test-qemu > >But as @travier said, this shouldn't be backported. It doesn't seem like there's a way to cancel a `/cherrypick` command, so we'll just have to close the PR it opens. Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 2 months ago

@aleskandro: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-cherrypick-robot commented 2 months ago

@aleskandro: new pull request created: #1543

In response to [this](https://github.com/openshift/os/pull/1541#issuecomment-2203082776): >/cherry-pick release-4.16 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.