search

openshift / ovirt-csi-driver

Other
14 stars 17 forks source link

Allow friendly names in disk description #48

Open benemon opened 4 years ago

benemon commented 4 years ago

As an OpenShift on oVirt/RHV Admin I want to put a friendly name in the disk description in oVirt/RHV So I can identify which disks in oVirt/RHV map to which OpenShift clusters when I have multiple OpenShift clusters deployed.

benemon commented 4 years ago

My initial thought on this would be an extra parameter in the StorageClass which allowed for a custom identifier to be mapped to the 'Description' field on the ovirt/RHV disk.

bennyz commented 4 years ago

Do you mean a key like "cluster1" that will be pre/appended to the description like: "cluster1-pvc-"? (sorry for the late reply by the way, I forgot to set notifications for this repo)

benemon commented 4 years ago

Not a problem @bennyz

A pre/appended key would also work - basically anything that would identify to an admin / user exactly which PVs belong to which cluster. I suggested Description as it is currently undefined for the disks, so it might have been simpler to implement.

bennyz commented 4 years ago

Ah, sorry, I confused alias with description. Anyway, this sounds like a good idea and I see no reason not support this, I'll add a ticket to track this

Thanks!

benemon commented 4 years ago

Awesome, thanks!

openshift-bot commented 3 years ago

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

bennyz commented 3 years ago

/lifecycle frozen