search

openshift / pipelines-tutorial

A step-by-step tutorial showing OpenShift Pipelines
Apache License 2.0
298 stars 621 forks source link

Add Trigger CRD to connect TriggerTemplate and Bindings #102

Closed khrm closed 3 years ago

khrm commented 3 years ago

Updated tutorial to have TriggerCRD object and use it as ref inside the EventListener.

khrm commented 3 years ago

@vdemeester @savitaashture Please review this.

openshift-ci-robot commented 3 years ago

@savitaashture: changing LGTM is restricted to collaborators

In response to [this](https://github.com/openshift/pipelines-tutorial/pull/102#pullrequestreview-498758533): >/lgtm Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
khrm commented 3 years ago

@vdemeester We will remove EventListener from the steps in the next release. That would be created by the operator. So we want to do incremental changed.

vdemeester commented 3 years ago

@khrm thanks :hugs: /lgtm /approve

openshift-ci-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: khrm, savitaashture, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/pipelines-tutorial/blob/master/OWNERS)~~ [vdemeester] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment