openshift / pipelines-tutorial

A step-by-step tutorial showing OpenShift Pipelines
Apache License 2.0
298 stars 621 forks source link

Tutorial fails validating Task - update-deployment #122

Closed sthaha closed 3 years ago

sthaha commented 3 years ago

A recent commit to master has added a workspaces in the update-deployment task which isn't necessary and the tutorial fails to run successfully.

Version Info:

client version: dev          🙏😝
  ❯ git rev-parse --short HEAD
     9a414070

Pipeline version: v0.16.3
Triggers version: v0.8.1

Steps:

  ./demo.sh setup
  ./demo.sh run
❯ tkn tr desc build-and-deploy-run-jrcf5-update-deployment-z2wl8
Name:              build-and-deploy-run-jrcf5-update-deployment-z2wl8
Namespace:         pipelines-tutorial
Task Ref:          update-deployment
Service Account:   pipeline
Timeout:           1h0m0s
Labels:
 app.kubernetes.io/managed-by=tekton-pipelines
 tekton.dev/pipeline=build-and-deploy
 tekton.dev/pipelineRun=build-and-deploy-run-jrcf5
 tekton.dev/pipelineTask=update-deployment
 tekton.dev/task=update-deployment

🌡️  Status

STARTED          DURATION    STATUS
13 minutes ago   ---         Failed(TaskRunValidationFailed)              <<<<< Fails Validation 🤯
openshift-bot commented 3 years ago

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

openshift-bot commented 3 years ago

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten /remove-lifecycle stale

Preeticp commented 3 years ago

Since this PR: https://github.com/openshift/pipelines-tutorial/pull/123 is merged, this issue can be closed.

openshift-bot commented 3 years ago

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen. Mark the issue as fresh by commenting /remove-lifecycle rotten. Exclude this issue from closing again by commenting /lifecycle frozen.

/close

openshift-ci[bot] commented 3 years ago

@openshift-bot: Closing this issue.

In response to [this](https://github.com/openshift/pipelines-tutorial/issues/122#issuecomment-871676911): >Rotten issues close after 30d of inactivity. > >Reopen the issue by commenting `/reopen`. >Mark the issue as fresh by commenting `/remove-lifecycle rotten`. >Exclude this issue from closing again by commenting `/lifecycle frozen`. > >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.