search

openshift / pipelines-tutorial

A step-by-step tutorial showing OpenShift Pipelines
Apache License 2.0
298 stars 621 forks source link

Fix update-deployment task that does not need a workspace #123

Closed sthaha closed 3 years ago

sthaha commented 3 years ago

Issue: https://github.com/openshift/pipelines-tutorial/issues/122 Signed-off-by: Sunil Thaha sthaha@redhat.com

praveen4g0 commented 3 years ago

/lgtm

openshift-ci-robot commented 3 years ago

@praveen4g0: changing LGTM is restricted to collaborators

In response to [this](https://github.com/openshift/pipelines-tutorial/pull/123#issuecomment-764312381): >/lgtm Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci-robot commented 3 years ago

@piyush-garg: changing LGTM is restricted to collaborators

In response to [this](https://github.com/openshift/pipelines-tutorial/pull/123#pullrequestreview-573062063): >/lgtm Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
chmouel commented 3 years ago

/lgtm /approve

openshift-ci-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chmouel, piyush-garg, praveen4g0, sthaha

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/pipelines-tutorial/blob/master/OWNERS)~~ [chmouel,sthaha] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-bot commented 3 years ago

/retest

Please review the full test history for this PR and help us cut down flakes.