search

openshift / pipelines-tutorial

A step-by-step tutorial showing OpenShift Pipelines
Apache License 2.0
298 stars 619 forks source link

Update branch info for vote-api and vote-ui #129

Closed savitaashture closed 3 years ago

savitaashture commented 3 years ago

/cc @praveen4g0 @vdemeester

openshift-ci-robot commented 3 years ago

@savitaashture: GitHub didn't allow me to request PR reviews from the following users: praveen4g0.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to [this](https://github.com/openshift/pipelines-tutorial/pull/129): >/cc @praveen4g0 @vdemeester Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci-robot commented 3 years ago

@vdemeester: GitHub didn't allow me to request PR reviews from the following users: praveen4g0.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to [this](https://github.com/openshift/pipelines-tutorial/pull/129#pullrequestreview-584443494): >/cc @praveen4g0 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
praveen4g0 commented 3 years ago

looks good :heart: Verified against 1.3.0 :heavy_check_mark: /lgtm

openshift-ci-robot commented 3 years ago

@praveen4g0: changing LGTM is restricted to collaborators

In response to [this](https://github.com/openshift/pipelines-tutorial/pull/129#issuecomment-774119310): >looks good :heart: >Verified against 1.3.0 :heavy_check_mark: >/lgtm Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
chmouel commented 3 years ago

Something weird on PSI

153m        Warning   FailedScheduling   pod/pipeline-tutorial-check-pr-fetch-49nvd-pod-28d2n   error while running "VolumeBinding" prebind plugin for pod "pipeline-tutorial-check-pr-fetch-49nvd-pod-28d2n": Failed to bind volumes: timed out waiting for the condition
143m        Warning   FailedScheduling   pod/pipeline-tutorial-check-pr-fetch-49nvd-pod-28d2n   error while running "VolumeBinding" prebind plugin for pod "pipeline-tutorial-check-pr-fetch-49nvd-pod-28d2n": Failed to bind volumes: timed out waiting for the condition
123m        Warning   FailedScheduling   pod/pipeline-tutorial-check-pr-fetch-49nvd-pod-28d2n   error while running "VolumeBinding" prebind plugin for pod "pipeline-tutorial-check-pr-fetch-49nvd-pod-28d2n": Failed to bind volumes: timed out waiting for the condition
112m        Warning   FailedScheduling   pod/pipeline-tutorial-check-pr-fetch-49nvd-pod-28d2n   error while running "VolumeBinding" prebind plugin for pod "pipeline-tutorial-check-pr-fetch-49nvd-pod-28d2n": Failed to bind volumes: timed out waiting for the condition
103m        Warning   FailedScheduling   pod/pipeline-tutorial-check-pr-fetch-49nvd-pod-28d2n   skip schedule deleting pod: pull-129-d3fab-oq/pipeline-tutorial-check-pr-fetch-49nvd-pod-28d2n
103m        Warning   FailedScheduling   pod/pipeline-tutorial-check-pr-fetch-49nvd-pod-28d2n   error while running "VolumeBinding" prebind plugin for pod "pipeline-tutorial-check-pr-fetch-49nvd-pod-28d2n": Failed to bind volumes: pod "pull-129-d3fab-oq/pipeline-tutorial-check-pr-fetch-49nvd-pod-28d2n" does not exist any more
163m        N
chmouel commented 3 years ago

/retest

piyush-garg commented 3 years ago

/lgtm

openshift-ci-robot commented 3 years ago

@piyush-garg: changing LGTM is restricted to collaborators

In response to [this](https://github.com/openshift/pipelines-tutorial/pull/129#issuecomment-774891696): >/lgtm Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci-robot commented 3 years ago

@khrm: changing LGTM is restricted to collaborators

In response to [this](https://github.com/openshift/pipelines-tutorial/pull/129#pullrequestreview-585182074): >/lgtm Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
chmouel commented 3 years ago

/lgtm

Looking Good! 🤙🏽

chmouel commented 3 years ago

/approve

openshift-ci-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chmouel, khrm, piyush-garg, praveen4g0, savitaashture, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/pipelines-tutorial/blob/pipelines-1.3/OWNERS)~~ [chmouel,vdemeester] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment