search

openshift / pipelines-tutorial

A step-by-step tutorial showing OpenShift Pipelines
Apache License 2.0
298 stars 627 forks source link

Update changes for pipelines-1.4 branch #135

Closed savitaashture closed 3 years ago

praveen4g0 commented 3 years ago

/lgtm

praveen4g0 commented 3 years ago

@savitaashture should we expect another pr to master branch?

savitaashture commented 3 years ago

@savitaashture should we expect another pr to master branch?

@praveen4g0 PR to master to update vote api and ui links https://github.com/openshift/pipelines-tutorial/pull/136

praveen4g0 commented 3 years ago

@savitaashture we don't need now parameter TLSVERIFY set to false, in buildah cluster task

praveen4g0 commented 3 years ago

/lgtm

openshift-ci-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: praveen4g0, savitaashture To complete the pull request process, please assign siamaksade after the PR has been reviewed. You can assign the PR to them by writing /assign @siamaksade in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openshift/pipelines-tutorial/blob/pipelines-1.4/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment