search

openshift / pipelines-tutorial

A step-by-step tutorial showing OpenShift Pipelines
Apache License 2.0
298 stars 627 forks source link

Update 03_trigger.yaml #137

Closed jcakakpo closed 3 years ago

jcakakpo commented 3 years ago

Replaced "ref" with "name" under the template section of the trigger file.

openshift-ci-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jcakakpo To complete the pull request process, please assign chmouel after the PR has been reviewed. You can assign the PR to them by writing /assign @chmouel in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openshift/pipelines-tutorial/blob/pipelines-1.3/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
jcakakpo commented 3 years ago

[root@ansible_control_node pipeline]# oc create -f https://raw.githubusercontent.com/openshift/pipelines-tutorial/pipelines-1.3/03_triggers/03_trigger.yaml Error from server (BadRequest): error when creating "https://raw.githubusercontent.com/openshift/pipelines-tutorial/pipelines-1.3/03_triggers/03_trigger.yaml": admission webhook "webhook.triggers.tekton.dev" denied the request: mutation failed: cannot decode incoming new object: json: unknown field "ref"

praveen4g0 commented 3 years ago

@jcakakpo TP1.3 triggers version v0.10.2 Use template.ref to refer to trigger templates in a Trigger instead of template.name. The name field is deprecated and will be removed in a future release.

but ref should work with no surprises, can I know what is the trigger version you used to test this?

jcakakpo commented 3 years ago

@jcakakpo TP1.3 triggers version v0.10.2 Use template.ref to refer to trigger templates in a Trigger instead of template.name. The name field is deprecated and will be removed in a future release.

but ref should work with no surprises, can I know what is the trigger version you used to test this?

@praveen4g0 Here is the tkn version info Client version: 0.17.1 Pipeline version: v0.16.3 Triggers version: v0.8.1

praveen4g0 commented 3 years ago

ahh, I see triggers version is bit old for this branch, pipelines-1.2 should work for you in this case. :)

openshift-bot commented 3 years ago

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

openshift-bot commented 3 years ago

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten /remove-lifecycle stale

openshift-bot commented 3 years ago

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen. Mark the issue as fresh by commenting /remove-lifecycle rotten. Exclude this issue from closing again by commenting /lifecycle frozen.

/close

openshift-ci[bot] commented 3 years ago

@openshift-bot: Closed this PR.

In response to [this](https://github.com/openshift/pipelines-tutorial/pull/137#issuecomment-913842911): >Rotten issues close after 30d of inactivity. > >Reopen the issue by commenting `/reopen`. >Mark the issue as fresh by commenting `/remove-lifecycle rotten`. >Exclude this issue from closing again by commenting `/lifecycle frozen`. > >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.