search

openshift / pipelines-tutorial

A step-by-step tutorial showing OpenShift Pipelines
Apache License 2.0
298 stars 619 forks source link

Update pipelines-1.4 manifests #138

Closed praveen4g0 closed 3 years ago

praveen4g0 commented 3 years ago
nikhil-thomas commented 3 years ago

/lgtm

VeereshAradhya commented 3 years ago

Even in README.md it needs to be changed https://github.com/openshift/pipelines-tutorial#trigger-template

openshift-ci-robot commented 3 years ago

@khrm: changing LGTM is restricted to collaborators

In response to [this](https://github.com/openshift/pipelines-tutorial/pull/138#pullrequestreview-632115761): >/lgtm Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
ppitonak commented 3 years ago

/lgtm

VeereshAradhya commented 3 years ago

git url in the section https://github.com/openshift/pipelines-tutorial#trigger-pipeline needs to be changed to https://github.com/openshift/pipelines-vote-api/ and https://github.com/openshift/pipelines-vote-ui

VeereshAradhya commented 3 years ago

@savitaashture has already created a PR for the git URL link change https://github.com/openshift/pipelines-tutorial/pull/136/files /lgtm

openshift-ci-robot commented 3 years ago

@VeereshAradhya: changing LGTM is restricted to collaborators

In response to [this](https://github.com/openshift/pipelines-tutorial/pull/138#issuecomment-816571847): >@savitaashture has already created a PR for the git URL link change https://github.com/openshift/pipelines-tutorial/pull/136/files >/lgtm Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
nikhil-thomas commented 3 years ago

let us change the apply command in demo.sh to create, as apply command will not work with generateName.

edit: now i see, that it is the pipelinerun name.. please ignore the above comment :bow:

VeereshAradhya commented 3 years ago

Tested the YAML content in README.md. /lgtm

openshift-ci-robot commented 3 years ago

@VeereshAradhya: changing LGTM is restricted to collaborators

In response to [this](https://github.com/openshift/pipelines-tutorial/pull/138#issuecomment-817531775): >Tested the YAML content in README.md. >/lgtm Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
VeereshAradhya commented 3 years ago

/lgtm

openshift-ci-robot commented 3 years ago

@VeereshAradhya: changing LGTM is restricted to collaborators

In response to [this](https://github.com/openshift/pipelines-tutorial/pull/138#issuecomment-817834012): >/lgtm Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
ppitonak commented 3 years ago

@praveen4g0 just a note for the future...all changes should go to master branch first, then cherry-pick to release branch

ppitonak commented 3 years ago

/assign @vdemeester

chmouel commented 3 years ago

/lgtm /approve

openshift-ci-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chmouel, khrm, nikhil-thomas, ppitonak, praveen4g0, savitaashture, VeereshAradhya

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/pipelines-tutorial/blob/pipelines-1.4/OWNERS)~~ [chmouel] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment