search

openshift / pipelines-tutorial

A step-by-step tutorial showing OpenShift Pipelines
Apache License 2.0
298 stars 619 forks source link

Update triggers object to use v1beta1 #147

Closed savitaashture closed 2 years ago

savitaashture commented 2 years ago

Fixes: https://issues.redhat.com/browse/SRVKP-1627

/cc @praveen4g0 @VeereshAradhya @khrm

openshift-ci[bot] commented 2 years ago

@savitaashture: GitHub didn't allow me to request PR reviews from the following users: VeereshAradhya, khrm.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to [this](https://github.com/openshift/pipelines-tutorial/pull/147): >Fixes: https://issues.redhat.com/browse/SRVKP-1627 > >/cc @praveen4g0 @VeereshAradhya @khrm Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
vincent-pli commented 2 years ago

/woof

openshift-ci[bot] commented 2 years ago

@vincent-pli: dog image

In response to [this](https://github.com/openshift/pipelines-tutorial/pull/147#issuecomment-914143847): >/woof Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
savitaashture commented 2 years ago

@ppitonak @VeereshAradhya friendly reminder on testing this change :smile_cat:

ppitonak commented 2 years ago

@savitaashture we are waiting for some nighly build to test with ;)

openshift-ci[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: piyush-garg, ppitonak, savitaashture

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/pipelines-tutorial/blob/master/OWNERS)~~ [piyush-garg] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
vdemeester commented 2 years ago

@savitaashture @ppitonak we need to have this cherry-picked to the 1.6 branch right ?

ppitonak commented 2 years ago

@vdemeester yes