openshift / pipelines-tutorial

A step-by-step tutorial showing OpenShift Pipelines
Apache License 2.0
298 stars 619 forks source link

version update and typos #168

Closed rbaumgar closed 5 months ago

rbaumgar commented 11 months ago
openshift-bot commented 8 months ago

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

rbaumgar commented 8 months ago

/remove-lifecycle stale

piyush-garg commented 7 months ago

@rbaumgar can you please squash the commits. Also i did not get the name changes done in the README

rbaumgar commented 7 months ago

sorry, I don't know how I can help.

sudhishmk commented 5 months ago

You may also have to update api version in ResourceTemplate spec session of 02_template to "v1" as well.

rbaumgar commented 5 months ago

@sudhishmk done

rbaumgar commented 5 months ago

@sudhishmk: sorry I am not a git expert.

$ git rebase Current branch master is up to date.

sudhishmk commented 5 months ago

@sudhishmk: sorry I am not a git expert.

$ git rebase Current branch master is up to date.

You need to use git rebase in interactive mode, a quick search on how merge multiple commits should help.

openshift-ci[bot] commented 5 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rbaumgar

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
khrm commented 5 months ago

I was trying to push to your branch and it closed the PR. Let's recreate the PR with your commit.

khrm commented 5 months ago

OK. So I opened this PR with squashed commits: https://github.com/openshift/pipelines-tutorial/pull/171/commits