openshift / pipelines-tutorial

A step-by-step tutorial showing OpenShift Pipelines
Apache License 2.0
298 stars 619 forks source link

Updating the pipeline-1.14 branch readme links #175

Closed sudhishmk closed 4 months ago

sudhishmk commented 5 months ago

Updated all links for branch pipelines-1.14 with links from pipelines-1.14 instead of master branch.

savitaashture commented 5 months ago

/hold

savitaashture commented 5 months ago

@sudhishmk you need to update the links for frontend to -> https://github.com/openshift/pipelines-vote-ui/tree/pipelines-1.4 and backend to -> https://github.com/openshift/pipelines-vote-api/tree/pipelines-1.14 in the readme

khrm commented 5 months ago

Like here: https://github.com/openshift/pipelines-tutorial/commit/04be42b0c59a9d85451a54a4cba12212371e7011

sudhishmk commented 5 months ago

@sudhishmk you need to update the links for frontend to -> https://github.com/openshift/pipelines-vote-ui/tree/pipelines-1.4 and backend to -> https://github.com/openshift/pipelines-vote-api/tree/pipelines-1.14 in the readme

updated

sudhishmk commented 5 months ago

We also need to change pipeline and TriggerTemplate.

Done

khrm commented 5 months ago

@sudhishmk Change here also: https://github.com/openshift/pipelines-tutorial/pull/175/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5L336

sudhishmk commented 5 months ago

@sudhishmk Change here also: https://github.com/openshift/pipelines-tutorial/pull/175/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5L336

Done

savitaashture commented 5 months ago

/lgtm

openshift-ci[bot] commented 5 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: khrm, savitaashture, sudhishmk Once this PR has been reviewed and has the lgtm label, please assign chmouel for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openshift/pipelines-tutorial/blob/pipelines-1.14/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
khrm commented 4 months ago

/hold cancel