search

openshift / pipelines-tutorial

A step-by-step tutorial showing OpenShift Pipelines
Apache License 2.0
299 stars 631 forks source link

Update Tutorial for Openshift 4.2 and Pipelines 0.7.0 #35

Closed danielhelfand closed 4 years ago

danielhelfand commented 4 years ago

This pull request updates screenshots and directions of navigating the web console for OpenShift 4.2, including installation instructions.

It also updates the YAML for the pipeline in the README to match ARG updates needed for 0.7.0 if a user wants to create a pipeline through the web console.

Also corrects typos and edits some writing.

6 is still a big problem if using a cluster with LimitRange settings, and it might be worthwhile pointing this out somewhere in the README in a future pr. The workarounds in the issue should work to make sure the pipeline succeeds.

piyush-garg commented 4 years ago

/cc @siamaksade Can you please take a look

openshift-ci-robot commented 4 years ago

@piyush-garg: GitHub didn't allow me to request PR reviews from the following users: look, Can, you, please, take, a.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to [this](https://github.com/openshift/pipelines-tutorial/pull/35#issuecomment-555858438): >/cc @siamaksade Can you please take a look Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
siamaksade commented 4 years ago

/lgtm

piyush-garg commented 4 years ago

/approve

hrishin commented 4 years ago

/approve

chmouel commented 4 years ago

/lgtm /approve /meow

Thanks 🙇🏽‍♂️😻

openshift-ci-robot commented 4 years ago

@chmouel: cat image

In response to [this](https://github.com/openshift/pipelines-tutorial/pull/35#issuecomment-556984545): >/lgtm >/approve >/meow > >Thanks 🙇🏽‍♂️😻 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.