search

openshift / pipelines-tutorial

A step-by-step tutorial showing OpenShift Pipelines
Apache License 2.0
298 stars 623 forks source link

Update tutorial #41

Closed piyush-garg closed 4 years ago

piyush-garg commented 4 years ago

This will update the tutorial to use two lighweight applications which run fast and concept of DAG and frontend/backend application can be shown

PierreR commented 4 years ago

It would be nice to have an example that uses a Deployment instead of a DeploymentConfig. The openshift 4.x documentation states:

It is recommended to use Deployments unless you need a specific feature or behavior provided by DeploymentConfigs footnote:[https://docs.openshift.com/container-platform/4.2/applications/deployments/what-deployments-are.html]. Deployments do not support (yet) automatically rolling back to the last successfully deployed ReplicaSet in case of a failure.

Does openshift pipelines requires the usage of DeploymentConfig ?

PierreR commented 4 years ago

Also I believe the sentence:

You might have noticed that there are no references to the PetClinic Git repository and its image in the registry.

is now out-of-sync in the README.

sthaha commented 4 years ago

It would be nice to have an example that uses a Deployment instead of a DeploymentConfig. The openshift 4.x documentation states:

@PierreR what section in the PR are you referring to?

sthaha commented 4 years ago

/lgtm

openshift-ci-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: piyush-garg, sthaha

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/pipelines-tutorial/blob/master/OWNERS)~~ [sthaha] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment