openshift / pipelines-tutorial

A step-by-step tutorial showing OpenShift Pipelines
Apache License 2.0
299 stars 631 forks source link

Provide example usage that uses Deployment (instead of DeploymentConfig) #46

Closed PierreR closed 4 years ago

PierreR commented 4 years ago

It would be nice to have an example that uses a Deployment instead of a DeploymentConfig. The openshift 4.x documentation states:

It is recommended to use Deployments unless you need a specific feature or behavior provided by DeploymentConfigs footnote:[https://docs.openshift.com/container-platform/4.2/applications/deployments/what-deployments-are.html]. Deployments do not support (yet) automatically rolling back to the last successfully deployed ReplicaSet in case of a failure.

Does openshift pipelines requires the usage of DeploymentConfig ?

PierreR commented 4 years ago

I need to go through the recent changes to see if this is still relevant.