openshift / pipelines-tutorial

A step-by-step tutorial showing OpenShift Pipelines
Apache License 2.0
299 stars 631 forks source link

Create openshift-pipelines namespace before installing operator. #55

Closed bostrt closed 4 years ago

bostrt commented 4 years ago

Related to #11.

openshift-ci-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bostrt To complete the pull request process, please assign sthaha You can assign the PR to them by writing /assign @sthaha in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openshift/pipelines-tutorial/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
bostrt commented 4 years ago

/assign @sthaha

siamaksade commented 4 years ago

@bostrt the openshift-pipelines namespace is created by the pipelines operator. User would not need to create it

bostrt commented 4 years ago

@siamaksade i see that's happening now. not sure what led to me having to do this manually before.

/close

openshift-ci-robot commented 4 years ago

@bostrt: Closed this PR.

In response to [this](https://github.com/openshift/pipelines-tutorial/pull/55#issuecomment-583611233): >@siamaksade i see that's happening now. not sure what led to me having to do this manually before. > >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.