search

openshift / pipelines-tutorial

A step-by-step tutorial showing OpenShift Pipelines
Apache License 2.0
298 stars 621 forks source link

Update tutorial for OpenShift Pipelines v1.1 #88

Closed khrm closed 4 years ago

khrm commented 4 years ago

Remove the git-repo resource and leverage git-clone task and workspace instead. PVC has been used as workspace. Image resource has also been removed.

piyush-garg commented 4 years ago

/lgtm

openshift-ci-robot commented 4 years ago

@piyush-garg: changing LGTM is restricted to collaborators

In response to [this](https://github.com/openshift/pipelines-tutorial/pull/88#issuecomment-674647267): >/lgtm Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
savitaashture commented 4 years ago

/lgtm

openshift-ci-robot commented 4 years ago

@savitaashture: changing LGTM is restricted to collaborators

In response to [this](https://github.com/openshift/pipelines-tutorial/pull/88#issuecomment-674712092): >/lgtm Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: khrm, piyush-garg, savitaashture, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/pipelines-tutorial/blob/master/OWNERS)~~ [vdemeester] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
Preeticp commented 4 years ago

@khrm some minor nits, otherwise LGTM