search

openshift / pipelines-tutorial

A step-by-step tutorial showing OpenShift Pipelines
Apache License 2.0
298 stars 621 forks source link

Adding VolumeClaimTemplate to pipelines-tutorial #95

Closed VeereshAradhya closed 3 years ago

VeereshAradhya commented 3 years ago
piyush-garg commented 3 years ago

I think we can use volumeClaimTemplate in both pipelinerun, this means we can remove PVC yaml also update the docs accordingly

VeereshAradhya commented 3 years ago

@piyush-garg The idea is to use both VolumeClaimTemplate and PersistentVolumeClaim in the tutorial and by doing that we are providing example usages of both VolumeClaimTemplate and PersistentVolumeClaim to the user

khrm commented 3 years ago

I think we try to keep tutorial simple. That's why we will move to single git repo example. So having only one approach is fine too.

VeereshAradhya commented 3 years ago

@Preeticp @savitaashture WDYT? If you all agree I will update the PR to contain only VolumeClaimTemplate

savitaashture commented 3 years ago

Actually it will be good if we show how we can use VolumeClaimTemplate and PersistentVolumeClaim but if we are considering to keep tutorial simple then it make sense to use VolumeClaimTemplate :+1:

+1 to use VolumeClaimTemplate

piyush-garg commented 3 years ago

/lgtm

openshift-ci-robot commented 3 years ago

@piyush-garg: changing LGTM is restricted to collaborators

In response to [this](https://github.com/openshift/pipelines-tutorial/pull/95#issuecomment-690154053): >/lgtm Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci-robot commented 3 years ago

@savitaashture: changing LGTM is restricted to collaborators

In response to [this](https://github.com/openshift/pipelines-tutorial/pull/95#pullrequestreview-489370633): >/lgtm Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: piyush-garg, savitaashture, vdemeester, VeereshAradhya

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/pipelines-tutorial/blob/master/OWNERS)~~ [vdemeester] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment