search

openshift / puppet-openshift_origin

Puppet module to create OpenShift Brokers and Nodes. Can be used to create a full OpenShift Origin deployment.
http://forge.puppetlabs.com/openshift/openshift_origin
Other
45 stars 128 forks source link

Fixed a bug which appears when hostname contains a point (.) #260

Open Antoine-A opened 10 years ago

Antoine-A commented 10 years ago

Author: Antoine Abélard Date: Mon Aug 04 14:29:00 2014 +0100

With the current implementation, the OpenShift Origin deployment fails when there is point (.) in the hostname. This new implementation fix this bug.

ekohl commented 10 years ago

What do you mean by a dot in the hostname? Do you mean where hostname is host.sub.example.org and domain is example.org?

Antoine-A commented 10 years ago

Yes, the hostname host.sub.example.org and the domain example.org is a good example. With this example, the .split('.').first function will return just "host" instead of "host.sub" We can't just write that, because '::openshift_origin::nameserver_hostname' contains "host.sub.example.org" and we just need "host.sub"

ekohl commented 10 years ago

@Antoine-A bind understands fqdn. (note the dot at the end).

Antoine-A commented 10 years ago

@ekohl Ok, so you're right, it's a simpler solution

openshift-bot commented 9 years ago

Origin Action Required: Pull request cannot be automatically merged, please rebase your branch from latest HEAD and push again

detiber commented 9 years ago

@Antoine-A can you please rebase this PR?