incorrect PUBLIC_HOSTNAME and PUBLIC_IP values in /etc/openshift/node.conf

[ryanj]

In templates/node/node.conf.erb it looks like the PUBLIC_HOSTNAME and PUBLIC_IP need to be in populated via node_hostname and node_ip_addr in order to produce a valid node configuration file: /tmp/oo_install_configure_nodeX.example.com.pp

See https://github.com/openshift/puppet-openshift_origin/blob/master/templates/node/node.conf.erb#L3

During my last run of the installer, both of my node instances had incorrect values for these fields, causing several runtime errors.

[sdodson]

I think this is really just a documentation clarity issue. Does this documentation change help?

https://github.com/sdodson/puppet-openshift_origin/commit/f330462113720b308628563c019b1cbcff43b37e

[detiber]

Additionally, the current version f the installer explicitly sets the node_ip_addr and node_hostname variables for node hosts, though it looks like node_ip_addr is also used by register_dns.erb, so oo-install should actually be updated to set node_ip_addr for all hosts.

[ryanj]

For more background on this issue:

I ran the install script from install.openshift.com with public / floating IPs (from RH OS1). Even though the nodes were configured to use PUBLIC host and IP info, the INTERNAL network interface settings were listed in the node's pp config files.

I had to update the pp files by hand to get it to work correctly in a public cloud environment.

[sdodson]

I've opened a bug against openshift-extras to address this. As far as I can tell this is not a puppet is.