Add node_resource_limits config options

openshift / puppet-openshift_origin

Puppet module to create OpenShift Brokers and Nodes. Can be used to create a full OpenShift Origin deployment.

http://forge.puppetlabs.com/openshift/openshift_origin

Other

45 stars 128 forks source link

Add node_resource_limits config options #277

Closed andrewklau closed 10 years ago

detiber commented 10 years ago

Outside of the bold/plain text issue in the README file, lgtm

Actually, we should probably add a flag to support not managing the resource_limits.conf, since supporting all possible configurations of the file is beyond the current scope. I'm fine with defaulting to managing the file though.

detiber commented 10 years ago

[test] [extended:node,cartridge]

openshift-bot commented 10 years ago

Origin Test Results: FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests/2832/)

detiber commented 10 years ago

Relevent error message from test failures: Cgroups parameter cannot be set to value: memory.memsw.limit_in_bytes = undefined (KeyError)

detiber commented 10 years ago

[test] [extended:node,gear,cartridge]

openshift-bot commented 10 years ago

Evaluated for origin up to 27aa0a2e969550248e50c9f886d775b88b8a87f7

detiber commented 10 years ago

extended test failures were unrelated, merging.