Install of module fails (Version 4.0.0 +)

[fortinj66]

For some reason the distribution has: lrwxrwxrwx. 1 501 games 44 Aug 29 16:31 /etc/puppet/modules/openshift_origin/spec/fixtures/modules/openshift_origin -> /Users/harrison/Code/puppet-openshift_origin

As I don't have any directories/files in /Users/harrison/Code/puppet-openshift_origin the install fails.

I'm hoping this is an mistake as I can imagine needing to have a /Users/harrison directory structure on all my servers.

Regards.

--John Fortin

[fortinj66]

Here is a listing from the downloaded tarball where you can see the symbolic link:

[root@jef modules]# pwd /root/Downloads/openshift-openshift_origin-4.0.9/spec/fixtures/modules [root@jef modules]# ls -al total 28 drwxr-xr-x. 7 501 games 4096 May 7 12:15 . drwxr-xr-x. 4 501 games 4096 Aug 29 16:31 .. drwxr-xr-x. 7 501 games 4096 Aug 29 16:31 lokkit drwxr-xr-x. 7 501 games 4096 Aug 29 16:31 ntp lrwxrwxrwx. 1 501 games 44 Aug 29 16:31 openshift_origin -> /Users/harrison/Code/puppet-openshift_origin drwxr-xr-x. 5 501 games 4096 Aug 29 16:31 selinux_types drwxr-xr-x. 7 501 games 4096 Aug 29 16:31 stdlib drwxr-xr-x. 5 501 games 4096 May 7 12:15 sysctl [root@jef modules]#

[fortinj66]

and the actual install error:

[root@jef modules]# puppet module install openshift-openshift_origin --version 4.0.9 Notice: Preparing to install into /etc/puppet/modules ... Notice: Downloading from https://forgeapi.puppetlabs.com ... Notice: Installing -- do not interrupt ... Error: No such file or directory - /etc/puppet/modules/openshift_origin/spec/fixtures/modules/openshift_origin Error: Try 'puppet help module install' for usage [root@jef modules]# root@jef modules]# ls -al /etc/puppet/modules/openshift_origin/spec/fixtures/modules/openshift_origin lrwxrwxrwx. 1 root root 44 Aug 29 17:13 /etc/puppet/modules/openshift_origin/spec/fixtures/modules/openshift_origin -> /Users/harrison/Code/puppet-openshift_origin [root@jef modules]#

[ekohl]

It looks like the release has been generated incorrectly since spec/fixtures should never be shipped. It's only used to execute tests. @nhr can you do a release without those files?

[nhr]

@ekohl I have been building the module with:

puppet module build

from the root dir of the repo. What do I need to change to prevent the spec/fixtures stuff from being pulled in?

[ekohl]

@nhr not sure if puppet can ignore it itself, but I think rake clean or rake spec:clean should clean it up.

[ekohl]

Otherwise you could also rely on git.

[nhr]

Okay... I think the spec test implementation is still incorrect, because

bundle exec rake spec_clean

...is expecting an openshift_origin symlink to exist at spec/fixtures/modules/, but

bundle exec rake spec

...doesn't create it.

That said, I've repackaged puppet module v4.0.9 without the fixtures dir, so you should not encounter the phantom symlink problem again.

[fortinj66]

Thank you. I was able to verify that the change works.