search

openshift / puppet-openshift_origin

Puppet module to create OpenShift Brokers and Nodes. Can be used to create a full OpenShift Origin deployment.
http://forge.puppetlabs.com/openshift/openshift_origin
Other
45 stars 128 forks source link

Ensure /var/lib/openshift is mode 751 #292

Closed andrewklau closed 10 years ago

andrewklau commented 10 years ago

The default 755 allows users to poke around

detiber commented 10 years ago

[test]

openshift-bot commented 10 years ago

Origin Test Results: FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests/2949/)

detiber commented 10 years ago

[test] [extended: node,gear,cartridge]

detiber commented 10 years ago

Only test failure was the existing ruby 2.0 issue. @nhr if you remind me next week I'll help dig into the remaining issues we have for this test failure.

@Miciah @sosiouxme I'd like your feedback on this change, seems like a good idea, and if doesn't introduce any unexpected breakage, we should incorporate this into openshift.sh as well.

sosiouxme commented 10 years ago

Agreed, as long as it doesn't cause any test breakage.

Might want to consider setting SELinux context at the same time. If it's wrong (as in the case of creating and mounting a separate filesystem), quotacheck can fail.

detiber commented 10 years ago

re [test] [extended: node,gear,cartridge]

openshift-bot commented 10 years ago

Evaluated for origin up to d4fd248ecbb6948c7e74d2b714c145f4227c3359

sosiouxme commented 10 years ago

FWIW I already incorporated this in openshift.sh. Looks like tests went OK except for the known problem...