Introduce OSE specific configuration defaults

openshift / puppet-openshift_origin

Puppet module to create OpenShift Brokers and Nodes. Can be used to create a full OpenShift Origin deployment.

http://forge.puppetlabs.com/openshift/openshift_origin

Other

45 stars 128 forks source link

Introduce OSE specific configuration defaults #314

Closed sdodson closed 9 years ago

sdodson commented 9 years ago

This appears to be the only changes we need to make in order to support OSE and Origin in the same module.

I had hoped to make all these changes in the ::params subclass but then I realize that would make handling the class parameters far more difficult. Open to other suggestions.

sdodson commented 9 years ago

[test]

openshift-bot commented 9 years ago

Origin Test Results: Running (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests/3033/)

openshift-bot commented 9 years ago

Evaluated for origin up to fa8add2226b44c480338f97401a5452eea7d16d0

sdodson commented 9 years ago

@detiber @nhr You guys don't perhaps know of a better way to do this do you?

detiber commented 9 years ago

Other than the cartridge list comments, +1 from me.

sdodson commented 9 years ago

[merge]