search

openshift / puppet-openshift_origin

Puppet module to create OpenShift Brokers and Nodes. Can be used to create a full OpenShift Origin deployment.
http://forge.puppetlabs.com/openshift/openshift_origin
Other
45 stars 128 forks source link

Wherever we reference apache user add httpd package requirement #317

Closed sdodson closed 9 years ago

sdodson commented 9 years ago

This may be implicitly defined in many of the cases, but we'll go ahead and make the requirement on httpd package explicit wherever we set owner or group to 'apache'.

Resolves https://bugzilla.redhat.com/show_bug.cgi?id=1158271

sdodson commented 9 years ago

[test]

openshift-bot commented 9 years ago

Origin Test Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests/3056/)

sdodson commented 9 years ago

[test] I can't figure out why this would've failed here. Going to push through another test run.

sdodson commented 9 years ago

[test] now that we've cleaned up some improper quoting of undef which would lead to jbossews being installed in origin where it's unsupported

detiber commented 9 years ago

@sdodson I started looking at the test failures, I think the issue may be the version of puppet in use by the vagrant-openshift images (it is using puppet 2.7 from epel).

More specifically, the actual puppet error: [1;35merr: Could not prefetch sysctl_runtime provider 'sysctl_runtime': undefined method `execute' for Puppet::Util::Execution:Module

I'm wondering if something we changed or the sysctl module changed made it incompatible with 2.7

sdodson commented 9 years ago

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1

@jdetiber

That one confuses me as well, sysctl module hasn't changed recently and it shows up in the test results from a previous run that were ultimately successful.

The one that I suspect is the root cause is the DNS registration failure when provisioning the nameserver. Here's the success for reference : https://ci.openshift.redhat.com/jenkins/job/test_pull_requests/3031/consoleText

err: /Stage[main]/Openshift_origin::Role::Nameserver/Openshift_origin::Register_dns[register nameserver dns]/Exec[Register openshift.example.com]/returns: change from notrun to 0 failed: /bin/sh: Register: command not found

I've gone through and ensured all puppet modules match the version from a previously successful run and it's still failing. It's like ensure_resource or exec is failing to evaluate the template.

debug: ExecRegister openshift.example.com: Executing '/bin/sh-cRegister openshift.example.com' debug: Executing '/bin/sh -c Register openshift.example.com' err: /Stage[main]/Openshift_origin::Role::Nameserver/Openshift_origin::Register_dns[register nameserver dns]/Exec[Register openshift.example.com]/returns: change from notrun to 0 failed: /bin/sh: Register: command not found -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux)

iQEcBAEBAgAGBQJUVARaAAoJEMRr2CP2Mq29ib0IAIYXNkLWsqOeoVi9WMdR+dGz ikBtbrpCjJJ6hXHHEXFAOlh8Jgy87FWP2z3WE9IlM4NKPOOcCEFGrh8/5SqxUMy5 qR3y8UBaC0B7ofb1L7wvv2GNnAKFFHK6Vx6t+zzJxKlUEJU0UxHkvEHpNI78NLn9 Y2m1EI+25HC1SjwANs7+lYWPnO06XyRTCanW/xAxPCueipjB3TUwePTCLjmn0o6b kQRmq4D+WLoSugu0zzbZU3lTwZS9mGvRRDBCGzHsTpXCp7XB+cviQFt2+5ftod9y CT3cLguqWRYFsmMph4K+g1gS7/zmrWQ0siJCu7SiuEq/Ob4HV3pkBsuYyHHUsJA= =n7Qt -----END PGP SIGNATURE-----

openshift-bot commented 9 years ago

Evaluated for origin up to 62678382a7fd3b161388cc823029b3a2a57afac1