search

openshift / puppet-openshift_origin

Puppet module to create OpenShift Brokers and Nodes. Can be used to create a full OpenShift Origin deployment.
http://forge.puppetlabs.com/openshift/openshift_origin
Other
45 stars 128 forks source link

Refactor openshift_origin::register_dns to avoid using ensure_resource #326

Closed sdodson closed 9 years ago

sdodson commented 9 years ago

We've discovered that ensure_resource has a bug[1] that leads to the command parameter being ignored. This seems to be addressed by upgrading to Puppet 3.3.0 or later, however we don't want to force users to do that. Additionally, register_dns had a few issues, mostly centered around the fact that we were passing in a 'fqdn' that really wasn't a FQDN but instead strings like 'register $role dns' which would then call an exec titled 'Register $fqdn'. Hopefully this simplifies things a bit.

  1. https://tickets.puppetlabs.com/browse/MODULES-832
sdodson commented 9 years ago

[test]

openshift-bot commented 9 years ago

Origin Test Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests/3053/)

openshift-bot commented 9 years ago

Evaluated for origin up to f36b37c0599de1d165a038c430964c6594a91957

sdodson commented 9 years ago

This should resolve #325