openshift / puppet-openshift_origin

Puppet module to create OpenShift Brokers and Nodes. Can be used to create a full OpenShift Origin deployment.
http://forge.puppetlabs.com/openshift/openshift_origin
Other
45 stars 128 forks source link

Fix GSS-TSIG dns authentication #341

Closed sdodson closed 10 years ago

sdodson commented 10 years ago

In order to enable nsupdate via GSS-TSIG set bind_krb_principal and bind_krb_keytab

sdodson commented 10 years ago

[test]

There's no way the current code is working as it was looking for a class parameter that no longer exists so as long as the tests pass I'll merge this. I need to get a kerberos environment setup to test this on my own at some point in the future.

sdodson commented 10 years ago

@detiber mind taking a look at this to validate my assumptions are correct WRT to it never having worked in the past as it was.

openshift-bot commented 10 years ago

Origin Test Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests/3103/)

detiber commented 10 years ago

other than the 2 nitpicky comments :+1:

openshift-bot commented 10 years ago

Evaluated for origin up to a3e34bd008601e437b708597f5d9157ad5f93aae