search

openshift / puppet-openshift_origin

Puppet module to create OpenShift Brokers and Nodes. Can be used to create a full OpenShift Origin deployment.
http://forge.puppetlabs.com/openshift/openshift_origin
Other
45 stars 128 forks source link

Audit passwords and bind_key usage for proper quoting #348

Open sdodson opened 10 years ago

sdodson commented 10 years ago

In README.asciidoc we say

NOTE: Passwords used to secure various services. You are advised to specify
only alphanumeric values in this script as others may cause syntax
errors depending on context. If non-alphanumeric values are required,
update them separately after installation.

We should audit all situations where we deal with passwords and other strings which may contain special characters to ensure safety rather than suggesting users avoid special characters.

detiber commented 10 years ago

+1, I suspect the issue is where we are using those passwords in templated scripts (mongo configuration, register_dns, etc) as opposed to places we are just setting the passwords directly in the templated config files.

It is possible that we are failing to properly quote in some of ini style configs as well though.