openshift / puppet-openshift_origin

Puppet module to create OpenShift Brokers and Nodes. Can be used to create a full OpenShift Origin deployment.
http://forge.puppetlabs.com/openshift/openshift_origin
Other
45 stars 128 forks source link

Remove Fedora related code #353

Closed sdodson closed 9 years ago

sdodson commented 10 years ago

Fedora is no longer supported by Origin Release 4 and was obviously never supported by OSE so lets excise the Fedora specific code paths to simplify our code base.

Ref: https://fedoraproject.org/wiki/OpenShift_Origin

sdodson commented 10 years ago

[test]

openshift-bot commented 10 years ago

Origin Test Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests/3137/)

ekohl commented 10 years ago

I like the simplification. A further cleanup could be to move all rake tasks (such as asset compilation) to RPM packaging.

detiber commented 10 years ago

@ekohl, the asset compilation issue is a bit tricky, but the reason it should probably stay in place is because the openshift-origin-console package depends on assets shipped in the rubygem-openshift-origin-console package, and if the rubygem is shipped without a version of the openshift-origin-console package that was built with the newer rubygem, then the assets will be broken.

For enterprise, we ensure that this is the case, but the origin tooling that generates the release/nightly builds does not necessarily do this.

sdodson commented 10 years ago

@ekohl thanks. I've checked the rest of the params and they all seem to be used.

ekohl commented 9 years ago

@detiber I'm not that familiar with packaging of openshift, but it sounds like there should be a stricter dependency between the two packages. I'm assuming both packages are generated from the same source so maybe openshift-origin-console should have a dependency on rubygem-openshift-origin-console with the exact same version. I'm sure you agree if a simple yum install is guaranteed to work, everything (documentation, installation scripts, customer support) would be simplified so packaging is the correct place to fix the problem.

sdodson commented 9 years ago

@ekohl i'll make a note to check on that packaging issue, going to go ahead and merge this after my last rebase.

sdodson commented 9 years ago

[test] getting some spec test failures I wasn't expecting

sdodson commented 9 years ago

[test] again

ekohl commented 9 years ago

@sdodson yes, it's a different issue altogether and shouldn't hold this back.

sdodson commented 9 years ago

[test]

detiber commented 9 years ago

@ekohl, @sdodson, In reality, we probably wouldn't have to worry about the asset compilation issue anyway, the assets are generally updated infrequently, even when changes are made to rubygem-openshift-console. Perhaps we should just link to an article on the wiki telling how to 'fix' the issue with using rake to recompile the assets if needed?

ekohl commented 9 years ago

@detiber maybe we should create another issue to discuss it.

openshift-bot commented 9 years ago

Evaluated for origin up to 9d6cc2081f8ad0197bb73130942bd5820129f5a0