search

openshift / puppet-openshift_origin

Puppet module to create OpenShift Brokers and Nodes. Can be used to create a full OpenShift Origin deployment.
http://forge.puppetlabs.com/openshift/openshift_origin
Other
45 stars 128 forks source link

mcollective tls enhancements #357

Open sdodson opened 9 years ago

sdodson commented 9 years ago

Enhancements upon #334

andrewklau commented 9 years ago

I just realised my lower_fqdn change didn't end up working, https://github.com/openshift/puppet-openshift_origin/blob/master/manifests/init.pp#L773 this should be fixed before you bump the versions.

It should be something like, but it didn't end up working for me due to some kind of race condition: $lower_fqdn = downcase($::fqdn)

Sorry about that.

sdodson commented 9 years ago

Cool, merged your fixes, thanks.

I think the race condition is that you can't have class parameters that depend on the values of other class parameters because of https://tickets.puppetlabs.com/browse/PUP-1080

ekohl commented 9 years ago

That's correct. That's why the params.pp pattern exists.

sdodson commented 9 years ago

Our QE teams have filed this bug, I'm inclined to think this is just one of those things where we just have to expect people to fill in the right values, but it's worth considering if it could be fixed in puppet. I can't immediately think of any fixes though.

Bug 1172261 - [puppet] Cannot create activemq java keystore if fqdn != certname https://bugzilla.redhat.com/show_bug.cgi?id=1172261

andrewklau commented 9 years ago

I've opened a new PR #365 which should fix a few issues