search

openshift / puppet-openshift_origin

Puppet module to create OpenShift Brokers and Nodes. Can be used to create a full OpenShift Origin deployment.
http://forge.puppetlabs.com/openshift/openshift_origin
Other
45 stars 128 forks source link

Clean up to avoid unnecessary notices and service restarts #366

Closed andrewklau closed 9 years ago

andrewklau commented 9 years ago

Here are some tweaks I've been using for the past few months in my own fork which would avoid the notices being generated while using foreman, keeping the host being marked as active as it's not receiving the exit 0. Also without these changes, the broker service would be restarted every 30 minutes.

selinux_ignore_defaults is required to avoid the back and forth switching of label type.

ekohl commented 9 years ago

This is certainly a good goal which I fully support.

sdodson commented 9 years ago

Definitely in favor of this. I believe everything is in a good state to finally push out 4.1.2 unless our QE team tells me otherwise I'll try to do that tomorrow. Once that's out the door I'll work on getting this merged in.

sdodson commented 9 years ago

:+1:

No unexpected changes when run on an existing all-in-one install. Puppet run is reduced from 2m25s to 32s.

[test] to make sure this passes basic install tests

openshift-bot commented 9 years ago

Origin Test Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests/3202/)

openshift-bot commented 9 years ago

Evaluated for origin up to d598d3061088b59b7bfb74b1f822e817c3202e3a