Further clean up of notice level reports

[andrewklau]

Currently getting reports: /Stage[main]/Openshift_origin::Node/Exec[prevent_node_frontend_changes]/returns

I think this should prevent notices unless something actually changes.

[ekohl]

I'm unsure of the benefit of the diff in the first place. Another path you can take is to add an unless command that tests if the files are the same.

[sdodson]

@andrewklau Thanks, when I reviewed your last cleanup this was something I wanted to fix but you got to it first.

@ekohl The goal of this whole block of code is to allow puppet to ensure we deploy the preferred node frontend which may include altering the default node.conf but that we don't change the frontend after that point as changing the frontend requires manual steps.

[sdodson]

:+1:

[ekohl]

So diff returns an exit code if they differ and thus puppet execution fails?

[sdodson]

Yep, which blocks updating node.conf.