search

openshift / puppet-openshift_origin

Puppet module to create OpenShift Brokers and Nodes. Can be used to create a full OpenShift Origin deployment.
http://forge.puppetlabs.com/openshift/openshift_origin
Other
45 stars 128 forks source link

PROXY_PORTS_PER_GEAR vs PORTS_PER_USER #397

Closed sdodson closed 9 years ago

sdodson commented 9 years ago

Per https://github.com/openshift/origin-server/commit/18a380023392daadd0a5c8da96fb8f6ea1b5b08f there's been a change in config variables between M4 and more recent OSE releases. Need to conditionalize things based on ose_version

sdodson commented 9 years ago

Related to #392

IshentRas commented 9 years ago

I have just checked and I am 100% sure that OpenShift Origin has not changed the option names/values. Therefore, we shall propose new conditional statements based on ose_version parameter (::openshift_origin::ose_version) so as to determine when we should applied new naming convention or not.

IshentRas commented 9 years ago

The same is also valid for broker.conf

IshentRas commented 9 years ago

https://github.com/openshift/puppet-openshift_origin/pull/398